You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/15 08:57:14 UTC
Review Request 46259: Added authentication to `/metrics/snapshot`
endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46259/
-----------------------------------------------------------
Review request for mesos, Adam B and Alexander Rojas.
Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902
Repository: mesos
Description
-------
This patch adds authentication to the `/metrics/snapshot`
endpoint on the master and agent.
Diffs
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp 7abfadf6d030c52b7e03e773b67c74db6ad5b5df
3rdparty/libprocess/src/metrics/metrics.cpp 7677dffed98153bc6276aad492a6815e67740ea3
3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
Diff: https://reviews.apache.org/r/46259/diff/
Testing
-------
`sudo make check` on OSX
Thanks,
Greg Mann
Re: Review Request 46259: Added authentication to `/metrics/snapshot`
endpoint.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2016, 10:26 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/include/process/metrics/metrics.hpp, lines 55-58
> > <https://reviews.apache.org/r/46259/diff/1/?file=1346278#file1346278line55>
> >
> > trailing underscore?
See my comment on https://reviews.apache.org/r/46258/
> On April 22, 2016, 10:26 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/include/process/metrics/metrics.hpp, line 67
> > <https://reviews.apache.org/r/46259/diff/1/?file=1346278#file1346278line67>
> >
> > Any reason for not making it 'None()' by default to simplify the call site.
See my comment on https://reviews.apache.org/r/46258/: I don't think we can simplify the call site too much since different overloads of `route` are called; the authentication realm parameter only occurs in the signature of the authenticated overload, for example. What do you think?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46259/#review130206
-----------------------------------------------------------
On April 15, 2016, 6:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46259/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 6:57 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds authentication to the `/metrics/snapshot`
> endpoint on the master and agent.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 7abfadf6d030c52b7e03e773b67c74db6ad5b5df
> 3rdparty/libprocess/src/metrics/metrics.cpp 7677dffed98153bc6276aad492a6815e67740ea3
> 3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
>
> Diff: https://reviews.apache.org/r/46259/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46259: Added authentication to `/metrics/snapshot`
endpoint.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46259/#review130206
-----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/metrics.hpp (lines 55 - 58)
<https://reviews.apache.org/r/46259/#comment193914>
trailing underscore?
3rdparty/libprocess/include/process/metrics/metrics.hpp (line 67)
<https://reviews.apache.org/r/46259/#comment193916>
Any reason for not making it 'None()' by default to simplify the call site.
- Kapil Arya
On April 15, 2016, 2:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46259/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 2:57 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds authentication to the `/metrics/snapshot`
> endpoint on the master and agent.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 7abfadf6d030c52b7e03e773b67c74db6ad5b5df
> 3rdparty/libprocess/src/metrics/metrics.cpp 7677dffed98153bc6276aad492a6815e67740ea3
> 3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
>
> Diff: https://reviews.apache.org/r/46259/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46259: Added authentication to `/metrics/snapshot`
endpoint.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46259/#review130423
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On April 25, 2016, 10:21 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46259/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 10:21 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds authentication to the `/metrics/snapshot`
> endpoint on the master and agent.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 7abfadf6d030c52b7e03e773b67c74db6ad5b5df
> 3rdparty/libprocess/src/metrics/metrics.cpp 7677dffed98153bc6276aad492a6815e67740ea3
> 3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b
>
> Diff: https://reviews.apache.org/r/46259/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46259: Added authentication to `/metrics/snapshot`
endpoint.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46259/
-----------------------------------------------------------
(Updated April 25, 2016, 2:21 p.m.)
Review request for mesos, Adam B and Alexander Rojas.
Changes
-------
Commented out unused `principal` parameters.
Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902
Repository: mesos
Description
-------
This patch adds authentication to the `/metrics/snapshot`
endpoint on the master and agent.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp 7abfadf6d030c52b7e03e773b67c74db6ad5b5df
3rdparty/libprocess/src/metrics/metrics.cpp 7677dffed98153bc6276aad492a6815e67740ea3
3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b
Diff: https://reviews.apache.org/r/46259/diff/
Testing
-------
`sudo make check` on OSX
Thanks,
Greg Mann
Re: Review Request 46259: Added authentication to `/metrics/snapshot`
endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46259/#review129095
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 15, 2016, 8:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46259/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 8:57 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds authentication to the `/metrics/snapshot`
> endpoint on the master and agent.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 7abfadf6d030c52b7e03e773b67c74db6ad5b5df
> 3rdparty/libprocess/src/metrics/metrics.cpp 7677dffed98153bc6276aad492a6815e67740ea3
> 3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
>
> Diff: https://reviews.apache.org/r/46259/diff/
>
>
> Testing
> -------
>
> `sudo make check` on OSX
>
>
> Thanks,
>
> Greg Mann
>
>