You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Oleg Ignatenko (JIRA)" <ji...@apache.org> on 2019/02/18 12:23:00 UTC

[jira] [Commented] (IGNITE-11345) remove deprecation for beforeTestsStarted and afterTestsStopped

    [ https://issues.apache.org/jira/browse/IGNITE-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771041#comment-16771041 ] 

Oleg Ignatenko commented on IGNITE-11345:
-----------------------------------------

(i) No runs at Teamcity are needed for this change because presence nor absence of {{@Deprecated}} annotation can't impact tests execution in any way.

Note to reviewers: please make sure that diff contains exactly two lines commenting out {{@Deprecated}} annotation with the reference to IGNITE-11240 and that there is nothing else besides these two lines in the diff.

[~avinogradov] this is the change we discussed recently at dev list. If anything there is not as you expected, please let me know.

> remove deprecation for beforeTestsStarted and afterTestsStopped
> ---------------------------------------------------------------
>
>                 Key: IGNITE-11345
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11345
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 2.8
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.8
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This task is created per discussion at dev list: [beforeTestsStarted() was deprecated, what should we use instead?|http://apache-ignite-developers.2346864.n4.nabble.com/beforeTestsStarted-was-deprecated-what-should-we-use-instead-td40625.html]
> We are going to remove deprecation from {{beforeTestsStarted}} and {{afterTestsStopped}}. The reason for this is that the way recommended instead of these methods makes it less convenient to start and stop the grid.
> Note that regarding the mentioned inconvenient way, we also plan to improve it (IGNITE-11240). After it is done, we need to consider recovering deprecation for these methods because as follows from above, inconvenience of using the recommended way is the only reason to remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)