[GitHub] [qpid-jms] gemmellr commented on issue #32: QPIDJMS-441: add proxy support

[GitBox <gi...@apache.org>]

gemmellr commented on issue #32: QPIDJMS-441: add proxy support
URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-540529031
 
 
   We wouldn't want the JMS layer APIs to be directly dependent on fixed Netty types if we were to add this. There is as general setExtension method on the factory to be used rather than adding setters for each, the cases that do have one simply pre-dated the mechanism being added and were just reimplemented over it to leverage and exercise it. Ideally we also wouldn't have the proxy deps be required all the time either, but rather only needed if used, when the application would need to have/provide them anyway. I've made some example changes to that effect here: https://github.com/gemmellr/qpid-jms/tree/pr32-proxy
   
   We would need tests as you've mentioned, in order for the changes to be accepted. In that area, I'd wonder if interaction with SSL/TLS peers beyond a proxy would be currently be handled. To your question on the JIRA, I don't have any dependencies to suggest as this isnt an area I've ever looked at before, but essentially the main requirement is they be permissively licensed, and preferably relatively light weight. Peeking at some other projects using Netty, and indeed Netty itself, suggests many just use their own test HTTP and SOCKS proxies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org