You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/01 17:16:12 UTC

[GitHub] [solr] thelabdude opened a new pull request #715: SOLR-16009: Disable Calcite simplify config setting

thelabdude opened a new pull request #715:
URL: https://github.com/apache/solr/pull/715


   https://issues.apache.org/jira/browse/SOLR-16009
   
   # Description
   
   Force Calcite's `simplify` flag to false to avoid Calcite erasing query constructs that are meaningful for matching multi-valued fields, see test case from JIRA.
   
   # Solution
   
   Disabling the simplify action in Calcite (via `Hook.REL_BUILDER_SIMPLIFY`), allows WHERE clauses that match multi-valued fields. However, changing this property to `false` resulted in changes to the Logical query plan passed to `SolrFilter`, especially around `NOT BETWEEN` clauses (which required some refactoring in `SolrFilter`). However, we also got a nice fix to a previous problem that we worked around in a hacky way.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] thelabdude merged pull request #715: SOLR-16009: Disable Calcite simplify config setting

Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #715:
URL: https://github.com/apache/solr/pull/715


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org