You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/05/29 12:41:46 UTC

[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1225: fix issue 1166: treat all zk child path url as new child

Mulavar commented on a change in pull request #1225:
URL: https://github.com/apache/dubbo-go/pull/1225#discussion_r641933977



##########
File path: remoting/zookeeper/listener.go
##########
@@ -323,12 +319,24 @@ func (l *ZkEventListener) listenDirEvent(conf *common.URL, zkPath string, listen
 			}
 		}
 		// Periodically update provider information
-		ticker := time.NewTicker(ttl)
+		tickerTTL := ttl

Review comment:
       if ttl is less than 20e9, the timer may trigger too frequentyl?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org