You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/03/04 16:09:03 UTC

(superset) branch 3.1 updated (a45f27eb9c -> 4972fbe751)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a change to branch 3.1
in repository https://gitbox.apache.org/repos/asf/superset.git


 discard a45f27eb9c fix: Results section in Explore shows an infinite spinner (#27366)
     new 4972fbe751 fix: Results section in Explore shows an infinite spinner (#27366)

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (a45f27eb9c)
            \
             N -- N -- N   refs/heads/3.1 (4972fbe751)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../plugins/legacy-plugin-chart-heatmap/src/transformProps.js     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


(superset) 01/01: fix: Results section in Explore shows an infinite spinner (#27366)

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 4972fbe751b2c27d665e1cc5882c19c946a2b282
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Mon Mar 4 08:15:55 2024 -0500

    fix: Results section in Explore shows an infinite spinner (#27366)
    
    (cherry picked from commit 231e659b56617fcdefa7534e14ffcfe50a8c084c)
---
 .../plugins/legacy-plugin-chart-heatmap/src/transformProps.js     | 8 ++++----
 .../src/explore/components/DataTablesPane/DataTablesPane.tsx      | 3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js b/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js
index f58c58b724..ddafe456a6 100644
--- a/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js
+++ b/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js
@@ -58,14 +58,14 @@ export default function transformProps(chartProps) {
     coltypes[0] === GenericDataType.TEMPORAL
       ? getTimeFormatter(timeFormat)
       : coltypes[0] === GenericDataType.Numeric
-        ? Number
-        : String;
+      ? Number
+      : String;
   const yAxisFormatter =
     coltypes[1] === GenericDataType.TEMPORAL
       ? getTimeFormatter(timeFormat)
       : coltypes[1] === GenericDataType.Numeric
-        ? Number
-        : String;
+      ? Number
+      : String;
   return {
     width,
     height,
diff --git a/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx b/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
index 726f3ea468..60b65c6ffc 100644
--- a/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
+++ b/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
@@ -123,7 +123,8 @@ export const DataTablesPane = ({
     if (
       panelOpen &&
       activeTabKey.startsWith(ResultTypes.Results) &&
-      chartStatus === 'rendered'
+      chartStatus &&
+      chartStatus !== 'loading'
     ) {
       setIsRequest({
         results: true,