You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Niklas Gustavsson (JIRA)" <ji...@apache.org> on 2008/08/10 23:03:44 UTC

[jira] Created: (FTPSERVER-151) getClientCertificates does not work in explicit mode

getClientCertificates does not work in explicit mode
----------------------------------------------------

                 Key: FTPSERVER-151
                 URL: https://issues.apache.org/jira/browse/FTPSERVER-151
             Project: FtpServer
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.0-M2
            Reporter: Niklas Gustavsson
            Assignee: Niklas Gustavsson
             Fix For: 1.0-M3


Another possible issue regarding the name of the filters is the metod getClientCertificates() in FTPIoSession.java:
      if(getFilterChain().contains("sslFilter")) {
            SslFilter sslFilter = (SslFilter) getFilterChain().get("sslFilter");

Here, we only check if implicit SSL mode is set - and I guess we also want to be able to obtain the client certificate in explicit-ssl mode. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FTPSERVER-151) getClientCertificates does not work in explicit mode

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson closed FTPSERVER-151.
---------------------------------------

    Resolution: Fixed

Fixed and test added

svn commit "/media/big/home/svn/apache/ftpserver-trunk/core" -m "Crappy implementation of isSecure on the control socket as it only checked for the session base SSL filter  (FTPSERVER-149). Same (but opposite) problem for getClientCertificates() (FTPSERVER-151). Also, we should not allow AUTH to be issued on an already secure session or trouble will occur (multiple SSL filters) (FTPSERVER-154) All three fixed and tests added." --username "ngn"
	M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/command/AUTH.java
	M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/interfaces/FtpIoSession.java
	M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/resources/org/apache/ftpserver/message/FtpStatus.properties
	M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/ssl/ExplicitSecurityTestTemplate.java
	M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/ssl/MinaClientAuthTest.java
	  Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/command/AUTH.java
	  Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/interfaces/FtpIoSession.java
	  Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/resources/org/apache/ftpserver/message/FtpStatus.properties
	  Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/ssl/ExplicitSecurityTestTemplate.java
	  Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/ssl/MinaClientAuthTest.java
Committed revision 685647

> getClientCertificates does not work in explicit mode
> ----------------------------------------------------
>
>                 Key: FTPSERVER-151
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-151
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0-M2
>            Reporter: Niklas Gustavsson
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0-M3
>
>
> Another possible issue regarding the name of the filters is the metod getClientCertificates() in FTPIoSession.java:
>       if(getFilterChain().contains("sslFilter")) {
>             SslFilter sslFilter = (SslFilter) getFilterChain().get("sslFilter");
> Here, we only check if implicit SSL mode is set - and I guess we also want to be able to obtain the client certificate in explicit-ssl mode. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.