You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2018/12/12 00:05:00 UTC
[jira] [Commented] (HADOOP-15979) Add Netty support to the RPC
client
[ https://issues.apache.org/jira/browse/HADOOP-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718236#comment-16718236 ]
Daryn Sharp commented on HADOOP-15979:
--------------------------------------
Given that a stream-based interface is incongruent with Netty's design, I was surprisingly able to minimally inject Netty into the client.
I tried using a bootstrap to connect the socket but it made a bunch of tests fail that fiddle/mock/etc with the socket factory and I couldn't figure out how to set socket performance prefs before connecting, which negates the ability to specify connect time as the priority... So I usurp the socket after it's been connected. Made minor changes to {{IpcStreams}} to allow Netty to use its event loop instead of the parameter sending executor. Overall, the trickiest part was coordination the reading of data in the event loop and providing it to the connection thread.
I have not added parameterized tests nor am I sure all tests pass. I figure it's more important to get the patch up for early feedback since I will be disappearing for the rest of the year. The client can overall undoubtedly be improved such as the {{Connection}} instance not spawning a thread but instead being part of the event loop. However the goal here is quickly iterate (with no to low risk) to a much needed TLS impl.
I may get the next patch up if I get bored over xmas...
> Add Netty support to the RPC client
> -----------------------------------
>
> Key: HADOOP-15979
> URL: https://issues.apache.org/jira/browse/HADOOP-15979
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc, security
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Major
> Attachments: HADOOP-15979.patch
>
>
> Adding Netty will allow later using a native TLS transport layer with much better performance than that offered by Java's SSLEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org