[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #571: Add SessionAffinity and SessionAffinityConfig fields to ServiceOptions

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on code in PR #571:
URL: https://github.com/apache/solr-operator/pull/571#discussion_r1240023370


##########
helm/solr/README.md:
##########
@@ -300,6 +300,8 @@ When using the helm chart, omit `customSolrKubeOptions.`
 | statefulSetOptions.podManagementPolicy | string | `"Parallel"` | Policy for how Solr pods should be managed in the statefulSet, ["OrderedReady" or "Parallel"](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#pod-management-policies) |
 | commonServiceOptions.annotations | map[string]string |  | Custom annotations to add to the Solr common service |
 | commonServiceOptions.labels | map[string]string |  | Custom labels to add to the Solr common service |
+| commonServiceOptions.sessionAffinity | string |  | Used to maintain session affinity. Enable client IP based session affinity |

Review Comment:
   ```suggestion
   | commonServiceOptions.sessionAffinity | string | `"None"` | Choose session affinity to setup for the common service. Available options are "None" and "ClientIP". |
   ```



##########
api/v1beta1/common_types.go:
##########
@@ -169,9 +169,10 @@ type ServiceOptions struct {
 	// +optional
 	SessionAffinity string `json:"sessionAffinity,omitempty"`
 
-	// sessionAffinityConfig contains the configurations of session affinity.
 	// +optional
-	SessionAffinityConfig corev1.SessionAffinityConfig `json:"sessionAffinityConfig,omitempty"`
+	// +kubebuilder:default=None

Review Comment:
   These (the default and enum lines) were meant to be put up above with `sessionAffinity`, not `sessionAffinityConfig`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org