You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/11/28 19:33:21 UTC
Re: Review Request 54016: Fixed a few places to use `foreachkey` /
`foreachvalue`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54016/#review157124
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Nov. 22, 2016, 8:56 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54016/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2016, 8:56 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-6626
> https://issues.apache.org/jira/browse/MESOS-6626
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is preferrable to doing `foreach` over `hashmap::keys()` or
> `hashmap::values()`, respectively.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf
> src/slave/containerizer/fetcher.cpp d200c117579bc1c2d9d24f14bf4da8f650d3f562
>
> Diff: https://reviews.apache.org/r/54016/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>