You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by be...@apache.org on 2016/03/15 10:19:49 UTC
mesos git commit: Fixed placement of mock call expectation for
fetcher cache tests.
Repository: mesos
Updated Branches:
refs/heads/master 62bf9dc18 -> 35761379c
Fixed placement of mock call expectation for fetcher cache tests.
The EXPECT_CALL() statement in question should not be repeated in the
loop once per task. It should only be called exactly once before the
driver is started.
Review: https://reviews.apache.org/r/44710/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/35761379
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/35761379
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/35761379
Branch: refs/heads/master
Commit: 35761379c7b0d42ade71f265f4ab881b7a9d8697
Parents: 62bf9dc
Author: Bernd Mathiske <be...@mesosphere.io>
Authored: Tue Mar 15 10:19:21 2016 +0100
Committer: Bernd Mathiske <be...@mesosphere.io>
Committed: Tue Mar 15 10:19:21 2016 +0100
----------------------------------------------------------------------
src/tests/fetcher_cache_tests.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/35761379/src/tests/fetcher_cache_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/fetcher_cache_tests.cpp b/src/tests/fetcher_cache_tests.cpp
index f9c48f5..776c952 100644
--- a/src/tests/fetcher_cache_tests.cpp
+++ b/src/tests/fetcher_cache_tests.cpp
@@ -575,13 +575,13 @@ Try<vector<FetcherCacheTest::Task>> FetcherCacheTest::launchTasks(
result.push_back(Task {sandboxPath, taskStatusQueue});
- EXPECT_CALL(scheduler, statusUpdate(driver, _))
- .WillRepeatedly(PushIndexedTaskStatus<1>(result));
-
auto waypoint = Owned<Promise<Nothing>>(new Promise<Nothing>());
fetchContentionWaypoints.push_back(waypoint);
}
+ EXPECT_CALL(scheduler, statusUpdate(driver, _))
+ .WillRepeatedly(PushIndexedTaskStatus<1>(result));
+
driver->launchTasks(offer.id(), tasks);
return result;