You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by smilebrian0515 <gi...@git.apache.org> on 2018/11/14 03:38:50 UTC

[GitHub] logging-log4j2 pull request #239: Strings.toRootUpperCase add static

GitHub user smilebrian0515 opened a pull request:

    https://github.com/apache/logging-log4j2/pull/239

    Strings.toRootUpperCase  add static

    because Strings() is private
    and there is no getInstance  in this class.
    the others function are static, so I want to add 'static' for toRootUpperCase.
    
    sorry, my english is poor.
    thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smilebrian0515/logging-log4j2 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #239
    
----
commit b358374beb952f2f895b52132f08f2811ffa3a8a
Author: Brian <sm...@...>
Date:   2018-11-14T03:31:53Z

    Strings.toRootUpperCase  add static
    
    because String() is private
    and there is no getInstance  in this class.
    the others function are static, so I want to add 'static' for toRootUpperCase.
    
    sorry, my english is poor.

----


---