You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "albundy83 (via GitHub)" <gi...@apache.org> on 2025/06/25 22:35:59 UTC
[PR] Add api secret_key for 3.0+ instead of webserver secret_key [airflow]
albundy83 opened a new pull request, #52269:
URL: https://github.com/apache/airflow/pull/52269
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
related: [#52267](https://github.com/apache/airflow/issues/52267)
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
related: [#52267](https://github.com/apache/airflow/issues/52267)
Should resolve warning: /home/airflow/.local/lib/python3.12/site-packages/airflow/configuration.py:858 DeprecationWarning: The secret_key option in [webserver] has been moved to the secret_key option in [api] - the old setting has been used, but please update your config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use api secret_key for airflow 3.0+ instead of webserver secret_key [airflow]
Posted by "albundy83 (via GitHub)" <gi...@apache.org>.
albundy83 commented on PR #52269:
URL: https://github.com/apache/airflow/pull/52269#issuecomment-3029422297
Finally tests are ok :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use api secret_key for airflow 3.0+ instead of webserver secret_key [airflow]
Posted by "albundy83 (via GitHub)" <gi...@apache.org>.
albundy83 commented on PR #52269:
URL: https://github.com/apache/airflow/pull/52269#issuecomment-3028157294
My tests are now OK:
```
1459 passed, 3 warnings in 224.68s (0:03:44)
```
If someone can reapprove the workflow please :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add api secret_key for 3.0+ instead of webserver secret_key [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #52269:
URL: https://github.com/apache/airflow/pull/52269#issuecomment-3006437620
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use api secret_key for airflow 3.0+ instead of webserver secret_key [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #52269:
URL: https://github.com/apache/airflow/pull/52269#issuecomment-3018940126
tests are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use api secret_key for airflow 3.0+ instead of webserver secret_key [airflow]
Posted by "albundy83 (via GitHub)" <gi...@apache.org>.
albundy83 commented on PR #52269:
URL: https://github.com/apache/airflow/pull/52269#issuecomment-3018972941
@eladkal maybe this [one](https://github.com/apache/airflow/pull/52269/commits/0005c3b2600a3ef69c4d507453db85a091467309) will fix, can you allow another tests please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use api secret_key for airflow 3.0+ instead of webserver secret_key [airflow]
Posted by "albundy83 (via GitHub)" <gi...@apache.org>.
albundy83 commented on PR #52269:
URL: https://github.com/apache/airflow/pull/52269#issuecomment-3020263763
Ok new commits :)
I have this [one](https://github.com/apache/airflow/actions/runs/15972898601/job/45063044226#step:5:1514) that I don't understand why it fails ...
If someone can help me to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use api secret_key for airflow 3.0+ instead of webserver secret_key [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham merged PR #52269:
URL: https://github.com/apache/airflow/pull/52269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use api secret_key for airflow 3.0+ instead of webserver secret_key [airflow]
Posted by "albundy83 (via GitHub)" <gi...@apache.org>.
albundy83 commented on PR #52269:
URL: https://github.com/apache/airflow/pull/52269#issuecomment-3018948009
> tests are failing
Yes I see that.
I will try to understand why ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org