You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/11/24 13:17:50 UTC
[I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
alamb opened a new issue, #18909:
URL: https://github.com/apache/datafusion/issues/18909
### Is your feature request related to a problem or challenge?
Follow on to
- https://github.com/apache/datafusion/issues/17721
- https://github.com/apache/datafusion/issues/16643
- #14587
Requires
### Describe the solution you'd like
Now that DataFusion 51.0.0 is released, It would be great to update ClickBench https://benchmark.clickhouse.com/ with the newest version and highlight and improvement
ClickBench is a benchmark heavy on filtering and aggregation that we have used as an optimization target for the last several releases.
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3572320459
I am actively running / testing here. I will write up my findings hopefully later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3750927037
Saw this on linkedin - Polars is showcasing their performance too - https://www.linkedin.com/posts/ritchievink_clickbench-now-runs-the-polars-streaming-activity-7417145713400160256-f77D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3570863626
Looks like
> By default, all tests are run on c6a.4xlarge VM in AWS with 500 GB gp2.
https://github.com/ClickHouse/ClickBench/tree/main?tab=readme-ov-file#systems-included
Also note @pmcgleenon 's code: I've created some [automation to run the clickbench tests](https://github.com/pmcgleenon/datafusion-clickbench-runner).
I am going to run it manually on the c6a.4xlarge initially and update the instructions, etc. Then I will make the results for the other machine types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #18909: Update ClickBench benchmarks with DataFusion 51.0.0
URL: https://github.com/apache/datafusion/issues/18909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3570821897
It looks like [DataFusion currently has parquet partitioned runs](https://benchmark.clickhouse.com/#system=+ti%20rud&type=-&machine=-&cluster_size=-&opensource=+s&tuned=+n&metric=combined&queries=-) for the following hardware
Here are the ones in the c6a class:
* c6a.4xlarge
* c6a.2xlarge
* c6a.xlarge
* c6a.large
Here is the c8g.4xlarge category
c8g.4xlarge
Some other interesting ones would be to run on t3a.small (2 vcpus)
* t3a.small
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3572903651
### Variance study
I also ran the benchmark for DataFusion 51 5 times in a row to spot check the variance between runs. I ran the same benchmark with the same script on the same machine type like this:
```shell
# Test variance by running the benchmark for DataFusion 51 5 times in a row
rm -f result.csv && bash benchmark.sh && ./save-result.sh 51-run1-c6a.4xlarge
rm -f result.csv && bash benchmark.sh && ./save-result.sh 51-run2-c6a.4xlarge
rm -f result.csv && bash benchmark.sh && ./save-result.sh 51-run3-c6a.4xlarge
rm -f result.csv && bash benchmark.sh && ./save-result.sh 51-run4-c6a.4xlarge
rm -f result.csv && bash benchmark.sh && ./save-result.sh 51-run5-c6a.4xlarge
```
My results varied by 7% between runs:
<img width="1537" height="1318" alt="Image" src="https://github.com/user-attachments/assets/453d4078-ff24-4bf5-9ce5-a346a0abe4f0" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3575781447
> > ### Variance study
> > My results varied by 7% between runs
>
> EBS? We've never found it to be very stable performance wise.
Yeah, according to https://github.com/ClickHouse/ClickBench?tab=readme-ov-file#systems-included
> By default, all tests are run on c6a.4xlarge VM in AWS with 500 GB gp2.
Which is what I ran my tests on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3572864231
# Metadata caching study
Given the way the scripts run, the metadata cache is not used for each run.
I confirmed that metadata caching makes a pretty significant difference by "prewarming" the cache by adding `select count(*) from hits;` to create.sql.
```shell
diff --git a/datafusion-partitioned/create.sql b/datafusion-partitioned/create.sql
index 3b3330c1..a01baa64 100644
--- a/datafusion-partitioned/create.sql
+++ b/datafusion-partitioned/create.sql
@@ -2,3 +2,5 @@ CREATE EXTERNAL TABLE hits
STORED AS PARQUET
LOCATION 'partitioned'
OPTIONS ('binary_as_string' 'true');
+-- prewarm metadata cache
+select count(*) from hits;
diff --git a/datafusion-partitioned/run.sh b/datafusion-partitioned/run.sh
index 0c5ed184..74bcb0c2 100755
--- a/datafusion-partitioned/run.sh
+++ b/datafusion-partitioned/run.sh
@@ -11,11 +11,11 @@ cat queries.sql | while read -r query; do
echo -n "["
for i in $(seq 1 $TRIES); do
- # 1. there will be two query result, one for creating table another for executing the select statement
- # 2. each query contains a "Query took xxx seconds", we just grep these 2 lines
- # 3. use sed to take the second line
+ # 1. there will be three query result, one for creating table, one to load metadata cache, and another for executing the select statement
+ # 2. each query contains a "Query took xxx seconds", we just grep these 3 lines
+ # 3. use sed to take the third line
# 4. use awk to take the number we want
- RES=$(datafusion-cli -f create.sql /tmp/query.sql 2>&1 | grep "Elapsed" |sed -n 2p | awk '{ print $2 }')
+ RES=$(datafusion-cli -f create.sql /tmp/query.sql 2>&1 | grep "Elapsed" |sed -n 3p | awk '{ print $2 }')
[[ $RES != "" ]] && \
echo -n "$RES" || \
echo -n "null"
```
Making this change results in a 20% benchmark improvement for DataFusion 51 on c6a.4xlarge
<img width="1172" height="1307" alt="Image" src="https://github.com/user-attachments/assets/b51218a7-3463-4fe4-b28c-5c785523a866" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3573294672
> ### Variance study
>
> My results varied by 7% between runs
EBS? We've never found it to be very stable performance wise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3752357556
Thanks for that information 💯
Do you think it's a good time to update clickbench result for version 52? The current result is a bit outdated (version 47). I can take this if it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3577837262
So the stack trace above shows that the "FilesStatisticsCache" is being consulted and I suspect being used in subsequent runs
https://github.com/apache/datafusion/blob/3c21b546a9acf9922229220d3ceca91a945cbf46/datafusion/catalog-listing/src/table.rs#L181-L180
However, the cache doesn't appear to be populated as part of CREATE TABLE for some reason
I looked into the code and it does appear that the statistics cache is attached directly to the ListingTable and instantiated (but not populated) when the table is created the first time: https://github.com/apache/datafusion/blob/3c21b546a9acf9922229220d3ceca91a945cbf46/datafusion/catalog-listing/src/table.rs#L227-L226
My next steps will be:
1. File a ticket that explains this in more detail
2. Try and wire up the statistics cache correctly so that DataFusion behaves the way the comments say it should
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3577686002
I did some profiling on q0:
```shell
ubuntu@ip-172-31-45-69:~/ClickBench/datafusion-partitioned$ cat create.sql
CREATE EXTERNAL TABLE hits
STORED AS PARQUET
LOCATION 'partitioned'
OPTIONS ('binary_as_string' 'true');
ubuntu@ip-172-31-45-69:~/ClickBench/datafusion-partitioned$ cat q0.sql
SELECT COUNT(*) FROM hits;
Then run
datafusion-cli -f create.sql -f q0.sql
```
And then looked at it with samply like this to mimic a "warm" run
```shell
ubuntu@ip-172-31-45-69:~/ClickBench/datafusion-partitioned$ datafusion-cli -f create.sql -f q0.sql && samply record datafusion-cli -f create.sql -f q0.sql
```
My analysis is that 75% of the time is spent calculating statistics
<img width="1750" height="1164" alt="Image" src="https://github.com/user-attachments/assets/2bc9dfd9-6128-4063-a14a-561c3f64d2a3" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3577810018
Something seems off however, as according to https://datafusion.apache.org/user-guide/configs.html
datafusion.execution.collect_statistics | true | Should DataFusion collect statistics when first creating a table. Has no effect after the table is created. Applies to the default ListingTableProvider in DataFusion. Defaults to true.
-- | -- | --
In other words the statistics should have been gathered as part of the `CREATE TABLE` statement, but they appear to be collected as part of running the first `COUNT(*)` for some reason 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3572852114
I spent quite a while today running DataFusion with the ClickBench scripts on a `c6a.4xlarge` VM to try and understand the performance results that @pmcgleenon was seeing
Here is all the raw data if you want to look at it yourself (open index.html)
- [report.zip](https://github.com/user-attachments/files/23732361/report.zip)
<img width="677" height="983" alt="Image" src="https://github.com/user-attachments/assets/6948fef0-36b5-4975-9434-0a502f706afc" />
Conclusions:
1. I can reproduce the lack of improvement between DataFusion 47 and 51 (not sure the root cause, yet)
2. Cache parquet metadata will improve performance by 20% (details below).
3. There is significant variance between runs -- I saw up to 7% variance between runs on DataFusion 51 on c6a.4xlarge.
My next steps will be to more carefully profile what is going on in datafusion 47 vs 51 for some of the queriers and see where the time is being spent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3749452930
I spent some time running ClickBench on 52. Here is the result
<img width="706" height="1266" alt="Image" src="https://github.com/user-attachments/assets/7eaceab0-372b-4668-9d6b-e8bf81889a1e" />
Details: tuned nothing, just use `benchmark.sh` and only changed the git tag. with `c6a.4xlarge` VM in AWS with 500 GB gp2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3751897191
Thanks -- that is great news @waynexia
We also have a bunch of potential things coming up in the next arrow release (the Clickbench queries are so fast now that allocation overhead is starting to play a bigger role. I have some work to reduce them (e.g. https://github.com/apache/arrow-rs/issues/9061 and https://github.com/apache/arrow-rs/issues/9128)
We'll get there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3752497673
> Thanks for that information 💯
>
> Do you think it's a good time to update clickbench result for version 52? The current result is a bit outdated (version 47). I can take this if it's ok
That would be great 🙏
I played around with the scripts a bit here for DF 51 in case that is useful to you
- https://github.com/ClickHouse/ClickBench/pull/703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3572854475
# Background
The datafusion clickbench scripts build datafusion-cli like this: https://github.com/ClickHouse/ClickBench/tree/main/datafusion-partitioned
```shell
CARGO_PROFILE_RELEASE_LTO=true RUSTFLAGS="-C codegen-units=1" cargo build --release --package datafusion-cli --bin datafusion-cli
```
Then it clears the filesystem cache like this:
```shell
echo 3 | sudo tee /proc/sys/vm/drop_caches >/dev/null
```
Then it runs the queries like this:
```shell
./datafusion/target/release/datafusion-cli -f create.sql -f /tmp/query.sql
```
For example when running q0, the scripts look like this:
`create.sql`:
```sql
CREATE EXTERNAL TABLE hits
STORED AS PARQUET
LOCATION 'partitioned'
OPTIONS ('binary_as_string' 'true');
```
`/tmp/query.sql`
```sql
SELECT COUNT(*) FROM hits;
```
Implications:
1. Each query is run "cold" in the sense that datafusion-cli is started fresh and there is no metadata cache from previous runs. See notes below for how we could improve this if we wanted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update ClickBench benchmarks with DataFusion 51.0.0 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #18909:
URL: https://github.com/apache/datafusion/issues/18909#issuecomment-3582962182
- Filed ticket: https://github.com/apache/datafusion/issues/18952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org