You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/17 14:34:32 UTC
[GitHub] [incubator-seatunnel] bigdataf opened a new pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
bigdataf opened a new pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#issuecomment-1043626097
@asdf2014 Thank you very much, the doc format has been fixed, please review, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on a change in pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
bigdataf commented on a change in pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#discussion_r810411438
##########
File path: docs/en/flink/configuration/sink-plugins/Jdbc.md
##########
@@ -43,6 +44,10 @@ Insert statement
Number of writes per batch
+### parallelism [int]
+
+The parallelism of an individual operator, for JdbcSink.
+
### common options [string]
Sink plugin common parameters, please refer to [Sink Plugin](./sink-plugin.md) for details
Review comment:
Usually it should be needed. If it needs to be clear, it may be better to split source-plugin.md and sink-plugin.md, which will be more specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#issuecomment-1045700822
Please review if there are any other questions, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#discussion_r809615927
##########
File path: docs/en/flink/configuration/sink-plugins/Jdbc.md
##########
@@ -43,6 +44,10 @@ Insert statement
Number of writes per batch
+### parallelism [int]
+
+The parallelism of an individual operator, for JdbcSink.
+
### common options [string]
Sink plugin common parameters, please refer to [Sink Plugin](./sink-plugin.md) for details
Review comment:
`sink` doesn't seem to need `common options`, and `source` `common options` is `required` , please check, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#issuecomment-1046439530
@[leo65535](https://github.com/leo65535) This should be the time when the automatic compilation check, the network problem caused，Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 merged pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
leo65535 merged pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#discussion_r809596143
##########
File path: docs/en/flink/configuration/source-plugins/Jdbc.md
##########
@@ -17,6 +17,7 @@ Read data through jdbc
| query | string | yes | - |
| fetch_size | int | no | - |
| common-options | string | no | - |
+| parallelism | Int | no | - |
Review comment:
`Int` -> `int`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#issuecomment-1046422335
hi @bigdataf, can you check the failed action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1278: [Feature] [connector] For flink JdbcSource , JdbcSink and InfluxDbSource plugin supports parallel parameters
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1278:
URL: https://github.com/apache/incubator-seatunnel/pull/1278#discussion_r809122740
##########
File path: docs/en/flink/configuration/source-plugins/Jdbc.md
##########
@@ -17,6 +17,7 @@ Read data through jdbc
| query | string | yes | - |
| fetch_size | int | no | - |
| common-options | string | no | - |
+| parallelism | Int | no | - |
Review comment:
nit: it seems the `|` is not aligned
##########
File path: docs/en/flink/configuration/source-plugins/InfluxDb.md
##########
@@ -17,6 +17,7 @@ Read data from InfluxDB.
| measurement | `String` | yes | - |
| fields | `List<String>` | yes | - |
| field_types | `List<String>` | yes | - |
+| parallelism | `Int` | no | - |
Review comment:
nit: it seems the `|` is not aligned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org