You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jbuck <gi...@git.apache.org> on 2015/02/18 21:23:45 UTC
[GitHub] cordova-firefoxos pull request: CB-7567 Don't use adm-zip because ...
GitHub user jbuck opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/22
CB-7567 Don't use adm-zip because it creates invalid zip files
This patch is a fix for [CB-7567](https://issues.apache.org/jira/browse/CB-7567) where the current build step using [adm-zip creates invalid zip files](https://github.com/cthackers/adm-zip/issues/71). I switched to archiver because that's what our projects after_build script use, and what [cordova-browser uses](https://github.com/apache/cordova-browser/pull/10).
@stevengill I haven't contributed to Apache Cordova before. I know I need to sign the CLA. Is there anything else I need to do from a contribution standpoint?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbuck/cordova-firefoxos fix-zip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-firefoxos/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit bd21ce3b06db8ee6315c6ad591eef2f18265c037
Author: Jon Buckley <jo...@jbuckley.ca>
Date: 2015-02-18T16:13:43Z
CB-7567 Don't use adm-zip because it creates invalid zip files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-firefoxos pull request: CB-7567 Don't use adm-zip because ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-firefoxos/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org