[GitHub] [accumulo] dlmarion commented on a diff in pull request #2799: Adding support for setting multiple properties at once atomically

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #2799:
URL: https://github.com/apache/accumulo/pull/2799#discussion_r914716017


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -643,6 +664,9 @@ default Iterable<Entry<String,String>> getProperties(String tableName)
   Map<String,String> getConfiguration(String tableName)
       throws AccumuloException, TableNotFoundException;
 
+  Map<String,String> getTableSpecificConfiguration(String tableName)

Review Comment:
   How is this different than `getConfiguration` above?



##########
server/base/src/main/java/org/apache/accumulo/server/client/ClientServiceHandler.java:
##########
@@ -327,6 +336,14 @@ public Map<String,String> getTableConfiguration(TInfo tinfo, TCredentials creden
     return conf(credentials, config);
   }
 
+  @Override
+  public Map<String,String> getTableSpecificConfiguration(TInfo tinfo, TCredentials credentials,
+      String tableName) throws TException, ThriftTableOperationException {
+    return getTableConfiguration(tinfo, credentials, tableName).entrySet().stream()
+        .filter(entry -> Property.isValidTablePropertyKey(entry.getKey()))
+        .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
+  }

Review Comment:
   Do you have an example of invalid table properties that are being returned from `getTableConfiguration` ?



##########
core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperations.java:
##########
@@ -230,6 +234,9 @@ default Iterable<Entry<String,String>> getProperties(String namespace)
   Map<String,String> getConfiguration(String namespace)
       throws AccumuloException, AccumuloSecurityException, NamespaceNotFoundException;
 
+  Map<String,String> getNamespaceSpecificConfiguration(String namespace)

Review Comment:
   How is this different than `getConfiguration` above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org