You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/11/01 22:11:32 UTC

[GitHub] ccollins476ad opened a new pull request #1501: Misc. battery fixes

ccollins476ad opened a new pull request #1501: Misc. battery fixes
URL: https://github.com/apache/mynewt-core/pull/1501
 
 
   These are just some assorted `hw/battery` fixes.  The main change is:
   
   *hw/battery: Don't open battery device during init*
   
   **Prior to commit:** The battery shell opened the battery device at init time.  If the open failed, a sysinit panic was triggered.
   
   **After commit:** The battery shell opens the battery device as needed, per command.  If the open fails, the command fails with a `SYS_ENODEV` error.
   
   **Rationale:** A hardware fault may render the battery device inoperable.  It is better for the application to decide how to handle this condition rather than the shell triggering a crash.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services