You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "a1batr0ss (via GitHub)" <gi...@apache.org> on 2023/09/10 13:16:34 UTC
[GitHub] [commons-lang] a1batr0ss opened a new pull request, #1110: [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace()
a1batr0ss opened a new pull request, #1110:
URL: https://github.com/apache/commons-lang/pull/1110
JIRA: https://issues.apache.org/jira/browse/LANG-1705
Due to the possibility that the serialized object type may be a different type after overriding writeReplace(), directly converting the serialized object to the original type(the type of parameter) will result in a ClassCastException.
Fix: Two templates are used for the return value and parameters of SerializationUtils.clone().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #1110: [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace()
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #1110:
URL: https://github.com/apache/commons-lang/pull/1110#discussion_r1324492443
##########
pom.xml:
##########
@@ -624,7 +624,7 @@
<checkstyle.configdir>src/site/resources/checkstyle</checkstyle.configdir>
- <japicmp.skip>false</japicmp.skip>
+ <japicmp.skip>true</japicmp.skip>
Review Comment:
-1, you cannot disable this check within a major release line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1110: [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace()
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1110:
URL: https://github.com/apache/commons-lang/pull/1110#issuecomment-1713731724
@a1batr0ss
Please run `mvn` -- which uses the default goal -- locally before pushing and you'll catch build failures like what just happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #1110: [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace()
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1110:
URL: https://github.com/apache/commons-lang/pull/1110#issuecomment-1712826004
## [Codecov](https://app.codecov.io/gh/apache/commons-lang/pull/1110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1110](https://app.codecov.io/gh/apache/commons-lang/pull/1110?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ecd17b1) into [master](https://app.codecov.io/gh/apache/commons-lang/commit/14be5e577767aa959510f7ebda8dc9647568a789?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (14be5e5) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #1110 +/- ##
=========================================
Coverage 92.19% 92.19%
Complexity 7548 7548
=========================================
Files 197 197
Lines 15805 15805
Branches 2922 2922
=========================================
Hits 14572 14572
Misses 661 661
Partials 572 572
```
| [Files Changed](https://app.codecov.io/gh/apache/commons-lang/pull/1110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/commons/lang3/SerializationUtils.java](https://app.codecov.io/gh/apache/commons-lang/pull/1110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU2VyaWFsaXphdGlvblV0aWxzLmphdmE=) | `88.88% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org