You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/04/17 18:26:34 UTC
[native-toolchain-CR] IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19753
Change subject: IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
......................................................................
IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
This removes some unused components and versions:
Boost 1.57.0-p3 - no longer used
Boost 1.61.0-p2 - no longer used
GDB 10.2 - never used
GDB 11.2 - never used
KRB 1.15.1 - Impala uses OS version
OpenSSL 1.0.2l - Impala uses OS version by default
Thrift 0.13.0-p4 - never used
Thrift 0.14.2-p4 - never used
The OpenSSL code in the Thrift build is dead code from
when we supported older OSes that had much older OpenSSL.
Impala does not use toolchain OpenSSL, but it will need
modifications to adapt to its absence.
This also fixes the Boost and Thrift builds to go parallel
properly. Boost had been limiting itself to 4 threads
unnecessarily. Thrift had been building serially. Now,
both go parallel with the specific BUILD_THREADS value.
Testing:
- Ran toolchain build
Change-Id: I07c21722c0849a1f6eeb3953a6e432d89623cf72
---
M buildall.sh
M init-compiler.sh
M source/boost/build.sh
M source/thrift/build.sh
4 files changed, 14 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/53/19753/1
--
To view, visit http://gerrit.cloudera.org:8080/19753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07c21722c0849a1f6eeb3953a6e432d89623cf72
Gerrit-Change-Number: 19753
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19753 )
Change subject: IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07c21722c0849a1f6eeb3953a6e432d89623cf72
Gerrit-Change-Number: 19753
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Apr 2023 18:30:54 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19753 )
Change subject: IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
......................................................................
IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
This removes some unused components and versions:
Boost 1.57.0-p3 - no longer used
Boost 1.61.0-p2 - no longer used
GDB 10.2 - never used
GDB 11.2 - never used
KRB 1.15.1 - Impala uses OS version
OpenSSL 1.0.2l - Impala uses OS version by default
Thrift 0.13.0-p4 - never used
Thrift 0.14.2-p4 - never used
The OpenSSL code in the Thrift build is dead code from
when we supported older OSes that had much older OpenSSL.
Impala does not use toolchain OpenSSL, but it will need
modifications to adapt to its absence.
This also fixes the Boost and Thrift builds to go parallel
properly. Boost had been limiting itself to 4 threads
unnecessarily. Thrift had been building serially. Now,
both go parallel with the specific BUILD_THREADS value.
Testing:
- Ran toolchain build
Change-Id: I07c21722c0849a1f6eeb3953a6e432d89623cf72
Reviewed-on: http://gerrit.cloudera.org:8080/19753
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
M init-compiler.sh
M source/boost/build.sh
M source/thrift/build.sh
4 files changed, 14 insertions(+), 34 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07c21722c0849a1f6eeb3953a6e432d89623cf72
Gerrit-Change-Number: 19753
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19753 )
Change subject: IMPALA-12064: Remove unused component versions (boost, thrift, openssl)
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07c21722c0849a1f6eeb3953a6e432d89623cf72
Gerrit-Change-Number: 19753
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 21:49:35 +0000
Gerrit-HasComments: No