[GitHub] [shardingsphere-elastic-job-lite] DoolinMa commented on a change in pull request #757: make elastic-job-lite-console can package and run

[GitBox <gi...@apache.org>]

DoolinMa commented on a change in pull request #757:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/757#discussion_r437125642



##########
File path: elastic-job-lite-console/pom.xml
##########
@@ -86,6 +86,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-assembly-plugin</artifactId>
+                <version>2.2-beta-5</version>

Review comment:
       thanks!
   
   Add id  like <id>console-bin</id> can resolve 2.x
   but 3.x have no goal assembly ,the goal should be single
   
   I have test all the version.
   I'm trying to use version 3. X

##########
File path: elastic-job-lite-console/pom.xml
##########
@@ -86,6 +86,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-assembly-plugin</artifactId>
+                <version>2.2-beta-5</version>

Review comment:
       I have tested all the versions，change maven-assembly-plugin version to 3.3.0.
   but it should be id in assembly.xml .please check.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org