You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by daniel voros <da...@gmail.com> on 2018/06/06 13:10:20 UTC
Review Request 67475: Different error msg on backend/frontend login
validation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-2123
https://issues.apache.org/jira/browse/RANGER-2123
Repository: ranger
Description
-------
Leaving the pass empty will result in a JS error, while a wrong password will get the server response:
```
The username or password you entered is incorrect..
```
vs
```
The username or password you entered is incorrect...
```
Lets go with a single '.' in both cases!
Diffs
-----
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 35d75438f
security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc
Diff: https://reviews.apache.org/r/67475/diff/1/
Testing
-------
Thanks,
daniel voros
Re: Review Request 67475: Different error msg on backend/frontend
login validation
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
> On June 12, 2018, 4:19 a.m., Mehul Parikh wrote:
> > @david : Your patch is still not getting applied, it is a diff file, if you can just make a patch file and attach it on review board. it will be helpful :
> >
> > As mentioned in Wiki page : https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244
> >
> > $ git add <modified|add|deleted-files>
> > $ git commit -m "RANGER-<JIRANUMBER>: <description of the JIRA fix>"
> > $ git format-patch -n HEAD~
>
> daniel voros wrote:
> @Mehul, sorry about that! I've reuploaded the patch, generated with format-patch. I was able to apply it with `git am`.
>
> p.s. my mom's calling me David sometimes, but I always thought it's because my older brother David. How did you know?! (:
:) - Apologies Daniel, mentioned David by mistake.
- Mehul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/#review204582
-----------------------------------------------------------
On June 6, 2018, 1:10 p.m., daniel voros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67475/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 1:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2123
> https://issues.apache.org/jira/browse/RANGER-2123
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Leaving the pass empty will result in a JS error, while a wrong password will get the server response:
> ```
> The username or password you entered is incorrect..
> ```
> vs
> ```
> The username or password you entered is incorrect...
> ```
> Lets go with a single '.' in both cases!
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 35d75438f
> security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc
>
>
> Diff: https://reviews.apache.org/r/67475/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daniel voros
>
>
Re: Review Request 67475: Different error msg on backend/frontend
login validation
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/#review204582
-----------------------------------------------------------
@david : Your patch is still not getting applied, it is a diff file, if you can just make a patch file and attach it on review board. it will be helpful :
As mentioned in Wiki page : https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244
$ git add <modified|add|deleted-files>
$ git commit -m "RANGER-<JIRANUMBER>: <description of the JIRA fix>"
$ git format-patch -n HEAD~
- Mehul Parikh
On June 6, 2018, 1:10 p.m., daniel voros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67475/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 1:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2123
> https://issues.apache.org/jira/browse/RANGER-2123
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Leaving the pass empty will result in a JS error, while a wrong password will get the server response:
> ```
> The username or password you entered is incorrect..
> ```
> vs
> ```
> The username or password you entered is incorrect...
> ```
> Lets go with a single '.' in both cases!
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 35d75438f
> security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc
>
>
> Diff: https://reviews.apache.org/r/67475/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daniel voros
>
>
Re: Review Request 67475: Different error msg on backend/frontend
login validation
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/#review204445
-----------------------------------------------------------
Ship it!
Ship It!
- Zsombor Gegesy
On June 6, 2018, 1:10 p.m., daniel voros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67475/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 1:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2123
> https://issues.apache.org/jira/browse/RANGER-2123
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Leaving the pass empty will result in a JS error, while a wrong password will get the server response:
> ```
> The username or password you entered is incorrect..
> ```
> vs
> ```
> The username or password you entered is incorrect...
> ```
> Lets go with a single '.' in both cases!
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 35d75438f
> security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc
>
>
> Diff: https://reviews.apache.org/r/67475/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daniel voros
>
>
Re: Review Request 67475: Different error msg on backend/frontend
login validation
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/#review204491
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
Line 83 (original), 83 (patched)
<https://reviews.apache.org/r/67475/#comment286969>
Could you please regenerate this patch? Not able to apply. Code seems fine.
```
$ git apply --check -v < ~/Downloads/RANGER-2123.1.patch
Checking patch src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java...
error: src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java: No such file or directory
Checking patch src/main/webapp/scripts/prelogin/XAPrelogin.js...
error: src/main/webapp/scripts/prelogin/XAPrelogin.js: No such file or directory
```
- Velmurugan Periasamy
On June 6, 2018, 1:10 p.m., daniel voros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67475/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 1:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2123
> https://issues.apache.org/jira/browse/RANGER-2123
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Leaving the pass empty will result in a JS error, while a wrong password will get the server response:
> ```
> The username or password you entered is incorrect..
> ```
> vs
> ```
> The username or password you entered is incorrect...
> ```
> Lets go with a single '.' in both cases!
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 35d75438f
> security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc
>
>
> Diff: https://reviews.apache.org/r/67475/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daniel voros
>
>
Re: Review Request 67475: Different error msg on backend/frontend
login validation
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/#review204579
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On June 6, 2018, 1:10 p.m., daniel voros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67475/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 1:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2123
> https://issues.apache.org/jira/browse/RANGER-2123
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Leaving the pass empty will result in a JS error, while a wrong password will get the server response:
> ```
> The username or password you entered is incorrect..
> ```
> vs
> ```
> The username or password you entered is incorrect...
> ```
> Lets go with a single '.' in both cases!
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 35d75438f
> security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc
>
>
> Diff: https://reviews.apache.org/r/67475/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daniel voros
>
>
Re: Review Request 67475: Different error msg on backend/frontend
login validation
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/#review204436
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On June 6, 2018, 1:10 p.m., daniel voros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67475/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 1:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2123
> https://issues.apache.org/jira/browse/RANGER-2123
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Leaving the pass empty will result in a JS error, while a wrong password will get the server response:
> ```
> The username or password you entered is incorrect..
> ```
> vs
> ```
> The username or password you entered is incorrect...
> ```
> Lets go with a single '.' in both cases!
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 35d75438f
> security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc
>
>
> Diff: https://reviews.apache.org/r/67475/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daniel voros
>
>