You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/12 18:05:15 UTC

[GitHub] cjolivier01 commented on a change in pull request #9398: [Make] add -Werror, warnings as errors

cjolivier01 commented on a change in pull request #9398: [Make] add -Werror, warnings as errors
URL: https://github.com/apache/incubator-mxnet/pull/9398#discussion_r161287694
 
 

 ##########
 File path: Makefile
 ##########
 @@ -53,7 +53,7 @@ include mshadow/make/mshadow.mk
 include $(DMLC_CORE)/make/dmlc.mk
 
 # all tge possible warning tread
-WARNFLAGS= -Wall -Wsign-compare
+WARNFLAGS= -Wall -Wsign-compare -Werror
 
 Review comment:
   This is something that would need to be discussed on dev.  Also, when developing, you don't want to have errors on warnings

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services