You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2020/02/13 14:22:59 UTC
Review Request 72131: ATLAS-3619 Allow to create a namespace typedef
without specifying any applicableEntityTypes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72131/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-3619
https://issues.apache.org/jira/browse/ATLAS-3619
Repository: atlas
Description
-------
Removed throw Exception statement
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1
Diff: https://reviews.apache.org/r/72131/diff/1/
Testing
-------
Thanks,
Mandar Ambawane
Re: Review Request 72131: ATLAS-3619 Allow to create a namespace
typedef without specifying any applicableEntityTypes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72131/#review219581
-----------------------------------------------------------
Mandar - the updates look good. In addition to this, I suggest removing following restrictions as well:
- namespaces can't have mandatory attributes (#87 - #89)
- namespaces can't have unique attributes (#91 - #93)
- Madhan Neethiraj
On Feb. 13, 2020, 2:22 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72131/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2020, 2:22 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3619
> https://issues.apache.org/jira/browse/ATLAS-3619
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Removed throw Exception statement
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1
>
>
> Diff: https://reviews.apache.org/r/72131/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 72131: ATLAS-3619 Allow to create a namespace
typedef without specifying any applicableEntityTypes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72131/#review219595
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 15, 2020, 3:13 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72131/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2020, 3:13 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3619
> https://issues.apache.org/jira/browse/ATLAS-3619
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Removed throw Exception statement
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1670bda
> intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1
>
>
> Diff: https://reviews.apache.org/r/72131/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 72131: ATLAS-3619 Allow to create a namespace
typedef without specifying any applicableEntityTypes
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72131/
-----------------------------------------------------------
(Updated Feb. 15, 2020, 3:13 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
Removed unused Error codes
Bugs: ATLAS-3619
https://issues.apache.org/jira/browse/ATLAS-3619
Repository: atlas
Description
-------
Removed throw Exception statement
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1670bda
intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1
Diff: https://reviews.apache.org/r/72131/diff/3/
Changes: https://reviews.apache.org/r/72131/diff/2-3/
Testing
-------
Thanks,
Mandar Ambawane
Re: Review Request 72131: ATLAS-3619 Allow to create a namespace
typedef without specifying any applicableEntityTypes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72131/#review219590
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java
Line 87 (original)
<https://reviews.apache.org/r/72131/#comment307771>
Error codes referenced in the removed code are no more used; please review and remove them as well (from AtlasErrorCode.java):
- NAMESPACE_DEF_MANDATORY_ATTRIBUTE_NOT_ALLOWED
- NAMESPACE_DEF_UNIQUE_ATTRIBUTE_NOT_ALLOWED
- MISSING_MANDATORY_ATTRIBUTE
- Madhan Neethiraj
On Feb. 14, 2020, 7:35 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72131/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2020, 7:35 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3619
> https://issues.apache.org/jira/browse/ATLAS-3619
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Removed throw Exception statement
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1
>
>
> Diff: https://reviews.apache.org/r/72131/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 72131: ATLAS-3619 Allow to create a namespace
typedef without specifying any applicableEntityTypes
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72131/
-----------------------------------------------------------
(Updated Feb. 14, 2020, 7:35 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
Changes to allow namespace to have mandatory as well as unique attributes
Bugs: ATLAS-3619
https://issues.apache.org/jira/browse/ATLAS-3619
Repository: atlas
Description
-------
Removed throw Exception statement
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1
Diff: https://reviews.apache.org/r/72131/diff/2/
Changes: https://reviews.apache.org/r/72131/diff/1-2/
Testing
-------
Thanks,
Mandar Ambawane