You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "liangyepianzhou (via GitHub)" <gi...@apache.org> on 2023/08/31 09:51:11 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request, #21103: [fix][test]Flaky test testMaxPendingChunkMessages
liangyepianzhou opened a new pull request, #21103:
URL: https://github.com/apache/pulsar/pull/21103
Fixes https://github.com/apache/pulsar/actions/runs/5934883964/job/16092673164?pr=21043
### Motivation
Fix the flaky test.
### Modifications
The root cause is `doAcknowledge` is an async method.
The chunk 1 may not be acked when call `redeliverUnacknowledgedMessages`.
```
doAcknowledge(msgId, AckType.Individual, Collections.emptyMap(), null);
```
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#issuecomment-1700786565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#issuecomment-1709415395
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21103](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (41a56cf) into [master](https://app.codecov.io/gh/apache/pulsar/commit/dab5b2f52685901bdc00b12063b203b2fb1c1bf3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dab5b2f) will **increase** coverage by `0.13%`.
> Report is 31 commits behind head on master.
> The diff coverage is `82.69%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21103 +/- ##
============================================
+ Coverage 73.03% 73.16% +0.13%
- Complexity 32363 32412 +49
============================================
Files 1887 1887
Lines 139860 140014 +154
Branches 15384 15423 +39
============================================
+ Hits 102140 102444 +304
+ Misses 29634 29451 -183
- Partials 8086 8119 +33
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21103/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21103/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.08% <7.69%> (?)` | |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21103/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `25.22% <3.84%> (+0.11%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21103/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.42% <82.69%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/pulsar/client/impl/ConsumerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0NvbnN1bWVySW1wbC5qYXZh) | `77.03% <71.42%> (+0.48%)` | :arrow_up: |
| [...he/pulsar/broker/resources/NamespaceResources.java](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvcmVzb3VyY2VzL05hbWVzcGFjZVJlc291cmNlcy5qYXZh) | `80.28% <75.00%> (-0.44%)` | :arrow_down: |
| [...roker/service/persistent/MessageDeduplication.java](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvTWVzc2FnZURlZHVwbGljYXRpb24uamF2YQ==) | `82.21% <89.47%> (+0.43%)` | :arrow_up: |
| [...pache/pulsar/broker/resources/PulsarResources.java](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvcmVzb3VyY2VzL1B1bHNhclJlc291cmNlcy5qYXZh) | `83.72% <100.00%> (ø)` | |
| [...g/apache/pulsar/client/impl/MessageIdAdvUtils.java](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL01lc3NhZ2VJZEFkdlV0aWxzLmphdmE=) | `84.61% <100.00%> (+1.28%)` | :arrow_up: |
| [...va/org/apache/pulsar/client/impl/ProducerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Byb2R1Y2VySW1wbC5qYXZh) | `82.56% <100.00%> (-0.72%)` | :arrow_down: |
| [...ache/pulsar/client/impl/UnAckedMessageTracker.java](https://app.codecov.io/gh/apache/pulsar/pull/21103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1VuQWNrZWRNZXNzYWdlVHJhY2tlci5qYXZh) | `91.59% <100.00%> (+0.91%)` | :arrow_up: |
... and [111 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21103/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on code in PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#discussion_r1317985914
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java:
##########
@@ -348,6 +363,10 @@ public void testMaxPendingChunkMessages() throws Exception {
assertEquals(receivedMsg.getValue(), "chunk-1-0|chunk-1-1|");
consumer.acknowledge(receivedMsg);
+ assertEquals(admin.topics().getStats(topicName).getSubscriptions().get(subName)
+ .getNonContiguousDeletedMessagesRanges(), 0);
Review Comment:
https://github.com/apache/pulsar/pull/21103/files#diff-9ce7ee7d161127cb26c5c43598bc3cf93021123b69a5f8669c988bdb2a36b795R368-R369 will fixed the flaky test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #21103:
URL: https://github.com/apache/pulsar/pull/21103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou commented on code in PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#discussion_r1317985260
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java:
##########
@@ -348,6 +363,10 @@ public void testMaxPendingChunkMessages() throws Exception {
assertEquals(receivedMsg.getValue(), "chunk-1-0|chunk-1-1|");
consumer.acknowledge(receivedMsg);
+ assertEquals(admin.topics().getStats(topicName).getSubscriptions().get(subName)
+ .getNonContiguousDeletedMessagesRanges(), 0);
Review Comment:
Oh, yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on a diff in pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on code in PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#discussion_r1317982697
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java:
##########
@@ -348,6 +363,10 @@ public void testMaxPendingChunkMessages() throws Exception {
assertEquals(receivedMsg.getValue(), "chunk-1-0|chunk-1-1|");
consumer.acknowledge(receivedMsg);
+ assertEquals(admin.topics().getStats(topicName).getSubscriptions().get(subName)
+ .getNonContiguousDeletedMessagesRanges(), 0);
Review Comment:
Need to remove this line?
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java:
##########
@@ -319,15 +320,29 @@ private void sendSingleChunk(Producer<String> producer, String uuid, int chunkId
msg.send();
}
+ /**
+ * This test used to test the consumer configuration of maxPendingChunkedMessage.
+ * If we set maxPendingChunkedMessage is 1 that means only one incomplete chunk message can be store in this
+ * consumer.
+ * For example:
+ * ChunkMessage1 chunk-1: uuid = 0, chunkId = 0, totalChunk = 2;
+ * ChunkMessage2 chunk-1: uuid = 1, chunkId = 0, totalChunk = 2;
+ * ChunkMessage2 chunk-2: uuid = 1, chunkId = 1, totalChunk = 2;
+ * ChunkMessage1 chunk-2: uuid = 0, chunkId = 1, totalChunk = 2;
+ * The chunk-1 in the ChunkMessage1 and ChunkMessage all is incomplete.
Review Comment:
```suggestion
* The chunk-1 in the ChunkMessage1 and ChunkMessage2 all is incomplete.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou commented on PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#issuecomment-1700928218
> 
@Technoboy That is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #21103: [fix][test]Flaky test testMaxPendingChunkMessages
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou commented on code in PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#discussion_r1317985260
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java:
##########
@@ -348,6 +363,10 @@ public void testMaxPendingChunkMessages() throws Exception {
assertEquals(receivedMsg.getValue(), "chunk-1-0|chunk-1-1|");
consumer.acknowledge(receivedMsg);
+ assertEquals(admin.topics().getStats(topicName).getSubscriptions().get(subName)
+ .getNonContiguousDeletedMessagesRanges(), 0);
Review Comment:
This line is used to fix this flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org