You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/02/26 20:57:31 UTC
[GitHub] [beam] rohdesamuel opened a new pull request #10980: Address
leftover styling comments from PR/10892
rohdesamuel opened a new pull request #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980
Change-Id: Ic8b4f23693d11bf5cd451c27527e6eb924aa8f98
Address leftover styling comments from PR/10892
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik merged pull request #10980: Address leftover
styling comments from PR/10892
Posted by GitBox <gi...@apache.org>.
lukecwik merged pull request #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #10980: Address leftover styling
comments from PR/10892
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#issuecomment-595951119
Ping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #10980: Address leftover styling
comments from PR/10892
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#issuecomment-592250235
pinging for update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #10980:
Address leftover styling comments from PR/10892
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#discussion_r384767097
##########
File path: sdks/python/apache_beam/testing/test_stream.py
##########
@@ -183,9 +182,20 @@ class TestStream(PTransform):
Each event emits elements, advances the watermark or advances the processing
time. After all of the specified elements are emitted, ceases to produce
output.
+
+ When expanded, if only the default output or only one output tag is specified,
+ then a PCollection will be returned. Otherwise, a dictionary of output names
+ to PCollection will be returned.
Review comment:
```suggestion
Applying the PTransform will return a single PCollection if only the default output or only one output tag has been used. Otherwise a dictionary of output names to PCollections will be returned.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] rohdesamuel commented on issue #10980: Address leftover
styling comments from PR/10892
Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on issue #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#issuecomment-591640091
R: @lukecwik
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #10980:
Address leftover styling comments from PR/10892
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#discussion_r384766435
##########
File path: sdks/python/apache_beam/testing/test_stream.py
##########
@@ -183,9 +182,20 @@ class TestStream(PTransform):
Each event emits elements, advances the watermark or advances the processing
time. After all of the specified elements are emitted, ceases to produce
output.
+
+ When expanded, if only the default output or only one output tag is specified,
+ then a PCollection will be returned. Otherwise, a dictionary of output names
+ to PCollection will be returned.
"""
def __init__(
self, coder=coders.FastPrimitivesCoder(), events=None, output_tags=None):
+ """
+ :param coder: The coder to encode/decode elements.
+ :param events: Events can be given and must be a subset of the output_tags.
+ :param output_tags: Can be specified to allow for adding outputs that
+ produce no output.
Review comment:
```suggestion
:param coder: The coder to encode/decode elements.
:param events: The initial set of events. If specified, the events tags must exist in the output_tags.
:param output_tags: Initial set of outputs. If no event references an output tag, no output will be produced for that tag.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #10980: Address leftover styling
comments from PR/10892
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#issuecomment-597819234
Ping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #10980:
Address leftover styling comments from PR/10892
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#discussion_r384763184
##########
File path: sdks/python/apache_beam/testing/test_stream.py
##########
@@ -148,9 +148,8 @@ def __lt__(self, other):
def to_runner_api(self, unused_element_coder):
tag = 'None' if self.tag is None else self.tag
- # Assert that no prevision is lost.
- assert 1000 * (
- self.new_watermark.micros // 1000) == self.new_watermark.micros
+ # Assert that no precision is lost.
+ assert self.new_watermark.micros % 1000 == 0
Review comment:
can you do this for processing time events as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services