You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Naparu <al...@outlook.com> on 2015/12/15 19:57:42 UTC
Re: Review Request 39888: Windows: Added compatibility code for
`grp.h` and `pwd.h`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110536
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 37)
<https://reviews.apache.org/r/39888/#comment170464>
Returning NULL without setting errno is probably not a good idea. We might want to standardize on '0' for group/user IDs on Windows.
- Alex Naparu
On Nov. 16, 2015, 9:15 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:15 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am a8c35c086ecae21701f6a720f25231c1b0d4e329
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39888/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39888: Windows: Added compatibility code for
`grp.h` and `pwd.h`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 15, 2015, 6:57 p.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp, line 37
> > <https://reviews.apache.org/r/39888/diff/2/?file=1126011#file1126011line37>
> >
> > Returning NULL without setting errno is probably not a good idea. We might want to standardize on '0' for group/user IDs on Windows.
Per our conversation, you proposed we set `ENOSYS` to indicate that the function is not implemented, and I thought that's great, so that's what we did. I also added a comment about that.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110536
-----------------------------------------------------------
On Dec. 15, 2015, 11:36 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39888/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 11:36 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This code will be particularly useful when we expand Windows support for
> `files/files.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am d1ef6f0df82e83d8e0d38f7b8986403702519a7d
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 43c85f50958dd9a7ee2ad7c32565585560486c69
>
> Diff: https://reviews.apache.org/r/39888/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>