[jira] [Commented] (SLING-5422) Sling Event - HistoryCleanUpTask removes Jobs younger than configured

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121823#comment-15121823 ] 

Carsten Ziegeler commented on SLING-5422:
-----------------------------------------

[~sseifert@pro-vision.de] I think I'm missing something: the patch only changes the last comparison (minute). If already the part for year/month etc is wrong, how does only changing this last bit fix the problem?
In general, if we have several areas with this problem, it would be great to fix all of them, even if they don't do any harm.

> Sling Event - HistoryCleanUpTask removes Jobs younger than configured
> ---------------------------------------------------------------------
>
>                 Key: SLING-5422
>                 URL: https://issues.apache.org/jira/browse/SLING-5422
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Event 4.0.0
>            Reporter: Christoph Nagel
>            Priority: Minor
>             Fix For: Event 4.1.0
>
>         Attachments: SLING-5422_cnagel.patch
>
>
> The HistoryCleanUpTask has to remove all Jobs stored in the JCR older than the given parameter {{age}} (a number of minutes).
> The current implementation traverses the _/var/eventing/jobs_ tree where parts of the path define the date of a job. Problem: the comparison of the job- and {{removeDate}} is wrong. First it compares the years, than months, weeks and days but this doesn't work.
> I've forked the project on github and wrote a test and fix. Further I added a test dependency for sling-mock in the pom.xml: [Fixes HistoryCleanUpTask date comparison|https://github.com/cnagel/sling/commit/165a8a04a129a4669599c6b15f48f67060e6c83c].
> Please have a look and if you like I can create a pull request on GitHub.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)