You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/03 19:47:27 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #19911: Fix mypy checks for api_connexion

kaxil commented on a change in pull request #19911:
URL: https://github.com/apache/airflow/pull/19911#discussion_r762201773



##########
File path: airflow/api_connexion/endpoints/dag_endpoint.py
##########
@@ -111,15 +110,15 @@ def patch_dag(session, dag_id, update_mask=None):
 
 @security.requires_access([(permissions.ACTION_CAN_DELETE, permissions.RESOURCE_DAG)])
 @provide_session
-def delete_dag(dag_id: str, session: Session):
+def delete_dag(dag_id: str, session):

Review comment:
       Isn't this change the same as just `type: ignore` -- we should keep the `Session` or just ignore it for now so we can identifying the pending changes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org