You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/21 15:35:00 UTC

[jira] [Commented] (SLING-7321) ChildResourceViaProvider should be able to deal with SlingHttpServletRequest

    [ https://issues.apache.org/jira/browse/SLING-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300174#comment-16300174 ] 

ASF GitHub Bot commented on SLING-7321:
---------------------------------------

santiagozky opened a new pull request #3: SLING-7321 ChildResourceViaProvider support wrapping request
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/3
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ChildResourceViaProvider should be able to deal with SlingHttpServletRequest
> ----------------------------------------------------------------------------
>
>                 Key: SLING-7321
>                 URL: https://issues.apache.org/jira/browse/SLING-7321
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Santiago GarcĂ­a Pimentel
>            Priority: Minor
>
> The ForcedResourceType and ResourceSuperType are able to deal with Sling requests by creating a wrapper request that returns a wrapped Request.
> Still, the ChildResourceViaProvider does not offer such possibility. I think that for sake of consistency it should.
> I propose that if the adaptable is a SlingHttpServletRequest the ChildResourceViaProvider  should create a request wrapper that returns the child as given in 'value'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)