You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/14 16:32:08 UTC

[GitHub] [kafka] dajac opened a new pull request #10879: MINOR: Fix unsafe access to `AbstractCoordinator.state`

dajac opened a new pull request #10879:
URL: https://github.com/apache/kafka/pull/10879


   We access the `state` from the `HeartbeatResponseHandler#handle` without synchronizing it. This seems unsafe to me as the `state` is not `volatile`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #10879: KAFKA-12991; Fix unsafe access to `AbstractCoordinator.state`

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10879:
URL: https://github.com/apache/kafka/pull/10879


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10879: MINOR: Fix unsafe access to `AbstractCoordinator.state`

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10879:
URL: https://github.com/apache/kafka/pull/10879#issuecomment-861269486


   @ableegoldman Good point. I have fixed those as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10879: MINOR: Fix unsafe access to `AbstractCoordinator.state`

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10879:
URL: https://github.com/apache/kafka/pull/10879#issuecomment-867735409


   Failed tests are not related:
   ```
   Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
   Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
   Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
   Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
   Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
   Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
   Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
   Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
   Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
   Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10879: KAFKA-12991; Fix unsafe access to `AbstractCoordinator.state`

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10879:
URL: https://github.com/apache/kafka/pull/10879#issuecomment-867875878


   Merged to trunk and 2.8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org