[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8211: epoll.h: Add u64 field like Linux

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #8211:
URL: https://github.com/apache/nuttx/pull/8211#discussion_r1087201829


##########
include/sys/epoll.h:
##########
@@ -91,11 +94,14 @@ enum
 #define EPOLL_CLOEXEC EPOLL_CLOEXEC
 };
 
-typedef union poll_data
+typedef union epoll_data
 {
   FAR void    *ptr;
   int          fd;
   uint32_t     u32;
+#ifdef CONFIG_HAVE_LONG_LONG
+  uint64_t     u64;
+#endif
 } epoll_data_t;

Review Comment:
   can we change to
   ```
   union epoll_data
   {
     FAR void    *ptr;
     int          fd;
     uint32_t     u32;
   #ifdef CONFIG_HAVE_LONG_LONG
     uint64_t     u64;
   #endif
   };
   
   typedef union epoll_data epoll_data_t;
   ```
   ?
   I think that is what is used in most of the files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org