You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/25 19:48:30 UTC

[kudu-CR] java: fix various integer-math error-prone issues 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10200

to review the following change.


Change subject: java: fix various integer-math error-prone issues
......................................................................

java: fix various integer-math error-prone issues

- Adds extra () around various bitwise math to clarify operator
  precedence (non-functional)

- Adds an upcast to 'long' to avoid potential overflow calculating the
  size of a write request. This shouldn't overflow in practice given
  other limits on write batch sizes.

- Removed some unused methods in Slices.java

This should be non-functional.

Change-Id: I515f64ab2a594588d952f6bd7f43451150c7ca9a
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slice.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
6 files changed, 9 insertions(+), 32 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/10200/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I515f64ab2a594588d952f6bd7f43451150c7ca9a
Gerrit-Change-Number: 10200
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] java: fix various integer-math error-prone issues

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10200 )

Change subject: java: fix various integer-math error-prone issues
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I515f64ab2a594588d952f6bd7f43451150c7ca9a
Gerrit-Change-Number: 10200
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 14:42:45 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix various integer-math error-prone issues

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10200 )

Change subject: java: fix various integer-math error-prone issues
......................................................................

java: fix various integer-math error-prone issues

- Adds extra () around various bitwise math to clarify operator
  precedence (non-functional)

- Adds an upcast to 'long' to avoid potential overflow calculating the
  size of a write request. This shouldn't overflow in practice given
  other limits on write batch sizes.

- Removed some unused methods in Slices.java

This should be non-functional.

Change-Id: I515f64ab2a594588d952f6bd7f43451150c7ca9a
Reviewed-on: http://gerrit.cloudera.org:8080/10200
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slice.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
6 files changed, 9 insertions(+), 32 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I515f64ab2a594588d952f6bd7f43451150c7ca9a
Gerrit-Change-Number: 10200
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] java: fix various integer-math error-prone issues

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10200 )

Change subject: java: fix various integer-math error-prone issues
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I515f64ab2a594588d952f6bd7f43451150c7ca9a
Gerrit-Change-Number: 10200
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 17:42:45 +0000
Gerrit-HasComments: No