[GitHub] [incubator-livy] tmnd1991 commented on a change in pull request #290: [LIVY-758] Document how to attach to an existing session from Java client

[GitBox <gi...@apache.org>]

tmnd1991 commented on a change in pull request #290: [LIVY-758] Document how to attach to an existing session from Java client
URL: https://github.com/apache/incubator-livy/pull/290#discussion_r409840092
 
 

 ##########
 File path: client-http/src/main/java/org/apache/livy/client/http/HttpClient.java
 ##########
 @@ -54,17 +55,18 @@
     this.config = httpConf;
     this.stopped = false;
 
-    // If the given URI looks like it refers to an existing session, then try to connect to
-    // an existing session. Note this means that any Spark configuration in httpConf will be
-    // unused.
-    Matcher m = Pattern.compile("(.*)" + LivyConnection.SESSIONS_URI + "/([0-9]+)")
-      .matcher(uri.getPath());
-
+    Matcher m = Pattern.compile("(.*)" + LivyConnection.SESSIONS_URI + "/([0-9]+)").matcher(uri.getPath());
 
 Review comment:
   I did it because the in-line comment was the *only* doc about connecting to an existing session. Now that is documented in the builder I don't think the inline comment is still needed, anyway no problem at all at reverting that change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services