You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/11 02:48:53 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #2424: feature: Add user state #1923
codecov-io edited a comment on pull request #2424:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2424#issuecomment-619503997
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424?src=pr&el=h1) Report
> Merging [#2424](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/cb5285384efc2fdbaecf129eb4404095eb8ef419&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2424 +/- ##
============================================
- Coverage 36.16% 36.16% -0.01%
- Complexity 2472 2473 +1
============================================
Files 431 431
Lines 19879 19893 +14
Branches 2419 2421 +2
============================================
+ Hits 7190 7194 +4
- Misses 12048 12055 +7
- Partials 641 644 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lphinscheduler/api/controller/UsersController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvVXNlcnNDb250cm9sbGVyLmphdmE=) | `3.57% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `80.95% <100.00%> (+4.48%)` | `6.00 <0.00> (+1.00)` | |
| [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `59.25% <100.00%> (+7.08%)` | `5.00 <0.00> (+1.00)` | |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `71.34% <100.00%> (+0.16%)` | `66.00 <0.00> (ø)` | |
| [...a/org/apache/dolphinscheduler/dao/entity/User.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Vc2VyLmphdmE=) | `72.41% <100.00%> (+1.50%)` | `27.00 <2.00> (+2.00)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `82.60% <0.00%> (-8.70%)` | `9.00% <0.00%> (-1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `71.42% <0.00%> (-6.35%)` | `14.00% <0.00%> (ø%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.07% <0.00%> (-2.88%)` | `9.00% <0.00%> (-2.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424?src=pr&el=footer). Last update [cb52853...1263869](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2424?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org