You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Maciej Szymkiewicz (Jira)" <ji...@apache.org> on 2020/01/28 14:31:00 UTC

[jira] [Updated] (SPARK-30663) Remove 1.x testthat switch once Jenkins version is updated to 2.x

     [ https://issues.apache.org/jira/browse/SPARK-30663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maciej Szymkiewicz updated SPARK-30663:
---------------------------------------
    Description: 
As part of SPARK-23435 proposal we include {{testthat}} 1.x compatibility mode 

{code}
    if (grepl("^1\\..*", packageVersion("testthat"))) {
                         NULL,	      # testthat 1.x
                         "summary")	      test_runner <- testthat:::run_tests
      reporter <- "summary"

    } else {
      # testthat >= 2.0.0
      test_runner <- testthat:::test_package_dir
      reporter <- testthat::default_reporter()
    }
{code}

in {{R/pkg/tests/run-all.R}}.

It should be removed once whole infrastructure uses {{testhat}} 2.x or later.

  was:
As part of SPARK-23435 proposal we include {{testthat}} 1.x compatibility mode 

{code}

    if (grepl("^1\\..*", packageVersion("testthat"))) {
                         NULL,	      # testthat 1.x
                         "summary")	      test_runner <- testthat:::run_tests
      reporter <- "summary"

    } else {
      # testthat >= 2.0.0
      test_runner <- testthat:::test_package_dir
      reporter <- testthat::default_reporter()
    }
{code}

It should be removed once whole infrastructure uses {{testhat}} 2.x or later.


> Remove 1.x testthat switch once Jenkins version is updated to 2.x
> -----------------------------------------------------------------
>
>                 Key: SPARK-30663
>                 URL: https://issues.apache.org/jira/browse/SPARK-30663
>             Project: Spark
>          Issue Type: Bug
>          Components: SparkR, Tests
>    Affects Versions: 3.0.0
>            Reporter: Maciej Szymkiewicz
>            Priority: Minor
>
> As part of SPARK-23435 proposal we include {{testthat}} 1.x compatibility mode 
> {code}
>     if (grepl("^1\\..*", packageVersion("testthat"))) {
>                          NULL,	      # testthat 1.x
>                          "summary")	      test_runner <- testthat:::run_tests
>       reporter <- "summary"
>     } else {
>       # testthat >= 2.0.0
>       test_runner <- testthat:::test_package_dir
>       reporter <- testthat::default_reporter()
>     }
> {code}
> in {{R/pkg/tests/run-all.R}}.
> It should be removed once whole infrastructure uses {{testhat}} 2.x or later.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org