You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/10/01 17:14:43 UTC

[GitHub] [lucene] romseygeek commented on pull request #11807: No need to rewrite queries in unified highlighter

romseygeek commented on PR #11807:
URL: https://github.com/apache/lucene/pull/11807#issuecomment-1264427197

   I ported the test in https://issues.apache.org/jira/secure/attachment/12919819/TestUnifiedHighlighterSurround.java to latest main, and I can confirm that it fails if you set `withWeightMatches(false)`.  But! It fails if the empty searcher rewrite is in place as well, so this change makes no difference to it.  So I think we should merge it anyway, as it doesn't seem to break anything that isn't already broken?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org