You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Khazar Mammadli (Code Review)" <ge...@cloudera.org> on 2022/09/21 21:52:46 UTC
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Khazar Mammadli has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19026
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS
Integration enabled
This patch adds the missing Input/Output formats and Serialization
library to table creation with Kudu HMS Integration. Patch also extends
the current test cases to cover added fields.
Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
6 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19026/1
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 1
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 3:
The fields we're also not set in the previous versions of Kudu as well. The bug looks to be there since the beginning. Checking the Hive logs for the previous versions of CDH with Kudu HMS enabled also showed these fields not being set during table creation.
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 3
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 16:01:32 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
KUDU-3401 Fix table creation with HMS Integration
Hive queries on Kudu Tables were failing with the following stack trace:
ERROR : Failed
org.apache.hadoop.hive.metastore.api.MetaException: java.lang.ClassNotFoundException Class not found
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:98)
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:77)
at org.apache.hadoop.hive.ql.metadata.Table.getDeserializerFromMetaStore(Table.java:331)
The issue was due to the Kudu HMS Client not sending the fields required
by Hive, namely the Input/Outputformat and Serialization library for the
created table when making a create table request. Thus, running queries through
Hive on Kudu tables would fail due to these fields missing in the HMS
Backend Database.
This patch adds the missing Input/Output formats and Serialization
library to table creation with Kudu HMS Integration.The patch also extends
the current test cases to cover the added fields. Manually tested on a
seperate cluster by creating a Kudu table with several columns via
"stored as kudu", confirmed the missing data is sent by checking the
parameters of the create_table request in Hive log files, and checked
that the data is written to the HMS Backend Database by going through the SDS
table for INPUT_FORMAT, OUTPUT_FORMAT and SERDES table for SLIB to see
if the data was filled for the newly created kudu table.
Ran a few Hive queries on the created Kudu tables and confirmed that no errors
are present.
Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Reviewed-on: http://gerrit.cloudera.org:8080/19026
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Tested-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
6 files changed, 32 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Zoltan Chovan: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 7
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 5:
> Thanks for following up on the fix. Did we get to the bottom of
> why/how were these fields set in older versions of Kudu where this
> issue wasn't encountered?
In the previous versions (without HMS integration) table creation goes through Impala and the SD fields(input/outputFormat and SerializationLibrary) for the table are populated by createSd().
With the Kudu HMS Integration enabled these fields we're not getting set when creating a table, although in hive_metastore.thrift for create_table request it is stated that these fields are necessary. The tests also did not check if the SD fields we're set when asserting table contents and that's how it went under the radar for a little while.
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 11:57:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19026
to look at the new patch set (#2).
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS
Integration enabled
This patch adds the missing Input/Output formats and Serialization
library to table creation with Kudu HMS Integration. Patch also extends
the current test cases to cover added fields.
Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
6 files changed, 32 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19026/2
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 2
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19026
to look at the new patch set (#5).
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
KUDU-3401 Fix table creation with HMS Integration
Hive queries on Kudu Tables were failing with the following stack trace:
ERROR : Failed
org.apache.hadoop.hive.metastore.api.MetaException: java.lang.ClassNotFoundException Class not found
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:98)
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:77)
at org.apache.hadoop.hive.ql.metadata.Table.getDeserializerFromMetaStore(Table.java:331)
The issue was due to the Kudu HMS Client not sending the fields required
by Hive, namely the Input/Outputformat and Serialization library for the
created table when making a create table request. Thus, running queries through
Hive on Kudu tables would fail due to these fields missing in the Hive Database.
This patch adds the missing Input/Output formats and Serialization
library to table creation with Kudu HMS Integration.The patch also extends
the current test cases to cover added fields. Manually tested on a
seperate cluster, confirmed the missing data is sent and written to the
Hive Backend Database, ran a few Hive queries on the created Kudu tables
and confirmed that no errors are present.
Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
6 files changed, 32 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19026/5
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 08:30:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19026
to look at the new patch set (#6).
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
KUDU-3401 Fix table creation with HMS Integration
Hive queries on Kudu Tables were failing with the following stack trace:
ERROR : Failed
org.apache.hadoop.hive.metastore.api.MetaException: java.lang.ClassNotFoundException Class not found
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:98)
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:77)
at org.apache.hadoop.hive.ql.metadata.Table.getDeserializerFromMetaStore(Table.java:331)
The issue was due to the Kudu HMS Client not sending the fields required
by Hive, namely the Input/Outputformat and Serialization library for the
created table when making a create table request. Thus, running queries through
Hive on Kudu tables would fail due to these fields missing in the HMS
Backend Database.
This patch adds the missing Input/Output formats and Serialization
library to table creation with Kudu HMS Integration.The patch also extends
the current test cases to cover the added fields. Manually tested on a
seperate cluster by creating a Kudu table with several columns via
"stored as kudu", confirmed the missing data is sent by checking the
parameters of the create_table request in Hive log files, and checked
that the data is written to the HMS Backend Database by going through the SDS
table for INPUT_FORMAT, OUTPUT_FORMAT and SERDES table for SLIB to see
if the data was filled for the newly created kudu table.
Ran a few Hive queries on the created Kudu tables and confirmed that no errors
are present.
Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
6 files changed, 32 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19026/6
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 08:30:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19026
to look at the new patch set (#3).
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS
Integration enabled
Hive queries on Kudu Tables we're failing with the following stack trace:
ERROR : Failed
org.apache.hadoop.hive.metastore.api.MetaException: java.lang.ClassNotFoundException Class not found
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:98)
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:77)
at org.apache.hadoop.hive.ql.metadata.Table.getDeserializerFromMetaStore(Table.java:331)
The issue was due to the Kudu Hms Client not sending the fields required
by Hive, namely the Input/Outputformat and Serialization library for the
created table when making a create table request. Thus, running queries through
Hive on Kudu tables would fail due to these fields missing in the Hive Database.
This patch adds the missing Input/Output formats and Serialization
library to table creation with Kudu HMS Integration. Patch also extends
the current test cases to cover added fields. Manually tested on a
seperate cluster, confirmed the missing data is sent and written to the
Hive Database.
Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
6 files changed, 32 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19026/3
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 3
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 5:
> Patch Set 5: Code-Review+1
>
> Ah okay makes sense. So some changes in the HMS side brought this issue on the Kudu side into light. Thanks for the clarification.
No, as far as I understood, these were never passed to the HMS. Input/OutputFormat and the Serde class was always a requirement from Hive side to be present.
However these are being passed when Impala is acting as the HMS-client.
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Sep 2022 08:26:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 11:26:26 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@25
PS3, Line 25: Manually tested on a
: seperate cluster, confirmed the missing data is sent and written to the
: Hive Database.
> Yes, the queries work fine, didn't run into any other errors.
Can you add this to the commit msg?
http://gerrit.cloudera.org:8080/#/c/19026/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/4//COMMIT_MSG@7
PS4, Line 7: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS
nit: shorten the subject line. Commit subjects shouldn't copy the JIRA subject. It should be concise, and explain what the commit will do when applied (e.g. "KUDU-1234 Fix something")
http://gerrit.cloudera.org:8080/#/c/19026/4//COMMIT_MSG@18
PS4, Line 18: Hms
nit: capitalize
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 4
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 14:55:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@20
PS5, Line 20: Hive Database
HMS backend database
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@24
PS5, Line 24:
nit: missing 'the'
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@24
PS5, Line 24: Manually tested
Please add details of the manual testing, how and what did you verify in the db.
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@26
PS5, Line 26: Hive
HMS
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Sep 2022 08:29:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19026/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/2//COMMIT_MSG@13
PS2, Line 13:
> Have you done any manual testing on a reproduction cluster? If so please in
Added the stack trace from the Jira and the results of my manual testing
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/hms/hms_client.cc
File src/kudu/hms/hms_client.cc:
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/hms/hms_client.cc@26
PS2, Line 26: #include <type_traits>
> what is this include used for?
IWYU resulted in this missing header
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/integration-tests/hms_itest-base.cc
File src/kudu/integration-tests/hms_itest-base.cc:
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/integration-tests/hms_itest-base.cc@23
PS2, Line 23: #include <type_traits>
> what is this include used for?
IWYU resulted in this missing header
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 2
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 18:15:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19026
to look at the new patch set (#4).
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS
Integration enabled
Hive queries on Kudu Tables were failing with the following stack trace:
ERROR : Failed
org.apache.hadoop.hive.metastore.api.MetaException: java.lang.ClassNotFoundException Class not found
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:98)
at org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:77)
at org.apache.hadoop.hive.ql.metadata.Table.getDeserializerFromMetaStore(Table.java:331)
The issue was due to the Kudu Hms Client not sending the fields required
by Hive, namely the Input/Outputformat and Serialization library for the
created table when making a create table request. Thus, running queries through
Hive on Kudu tables would fail due to these fields missing in the Hive Database.
This patch adds the missing Input/Output formats and Serialization
library to table creation with Kudu HMS Integration.The patch also extends
the current test cases to cover added fields. Manually tested on a
seperate cluster, confirmed the missing data is sent and written to the
Hive Database.
Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
6 files changed, 32 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19026/4
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 4
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@10
PS3, Line 10: we're
were
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@24
PS3, Line 24: Patch
nit: The patch
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@25
PS3, Line 25: Manually tested on a
: seperate cluster, confirmed the missing data is sent and written to the
: Hive Database.
Did you try to query Kudu tables from Hive? Has the error gone and is it working now?
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 3
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 10:02:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@20
PS5, Line 20: HMS
> HMS backend database
Done
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@24
PS5, Line 24: ation.The patch
> Please add details of the manual testing, how and what did you verify in th
Expanded it a bit more to explain the manual testing logic
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@24
PS5, Line 24: K
> nit: missing 'the'
Done
http://gerrit.cloudera.org:8080/#/c/19026/5//COMMIT_MSG@26
PS5, Line 26: sepe
> HMS
Done
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Sep 2022 13:07:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@25
PS3, Line 25: s sent and written to the
: Hive Backend Database, ran a few Hive queries on the created Kudu tables
: and confirmed
> Can you add this to the commit msg?
Done
http://gerrit.cloudera.org:8080/#/c/19026/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/4//COMMIT_MSG@7
PS4, Line 7: KUDU-3401 Fix table creation with HMS Integration
> nit: shorten the subject line. Commit subjects shouldn't copy the JIRA subj
Done
http://gerrit.cloudera.org:8080/#/c/19026/4//COMMIT_MSG@18
PS4, Line 18: utf
> nit: capitalize
Done
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 17:13:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 6
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 15:09:47 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
Patch Set 2:
(3 comments)
IF you've done
http://gerrit.cloudera.org:8080/#/c/19026/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/2//COMMIT_MSG@13
PS2, Line 13:
Have you done any manual testing on a reproduction cluster? If so please include details.
Do you have stack traces of the error? Might be good to include it here as well.
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/hms/hms_client.cc
File src/kudu/hms/hms_client.cc:
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/hms/hms_client.cc@26
PS2, Line 26: #include <type_traits>
what is this include used for?
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/integration-tests/hms_itest-base.cc
File src/kudu/integration-tests/hms_itest-base.cc:
http://gerrit.cloudera.org:8080/#/c/19026/2/src/kudu/integration-tests/hms_itest-base.cc@23
PS2, Line 23: #include <type_traits>
what is this include used for?
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 2
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 11:45:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
Posted by "Khazar Mammadli (Code Review)" <ge...@cloudera.org>.
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Unable to query Kudu tables from Hive with Kudu HMS Integration enabled
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@10
PS3, Line 10: we're
> were
Fixed
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@24
PS3, Line 24: Patch
> nit: The patch
Fixed
http://gerrit.cloudera.org:8080/#/c/19026/3//COMMIT_MSG@25
PS3, Line 25: Manually tested on a
: seperate cluster, confirmed the missing data is sent and written to the
: Hive Database.
> Did you try to query Kudu tables from Hive? Has the error gone and is it w
Yes, the queries work fine, didn't run into any other errors.
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 3
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 10:08:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 5:
Right, I was referring to older versions of Kudu when HMS integration was enabled for example release 1.10.0 or 1.11.0. Were these fields getting set then? If so how? I guess my main motive is we need to determine what broke it if it was working before.
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 14:59:55 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 5:
Thanks for following up on the fix. Did we get to the bottom of why/how were these fields set in older versions of Kudu where this issue wasn't encountered?
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 18:50:47 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3401 Fix table creation with HMS Integration
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19026 )
Change subject: KUDU-3401 Fix table creation with HMS Integration
......................................................................
Patch Set 5: Code-Review+1
Ah okay makes sense. So some changes in the HMS side brought this issue on the Kudu side into light. Thanks for the clarification.
--
To view, visit http://gerrit.cloudera.org:8080/19026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b53b55005e2899d8575b0fb7250351d914afb4
Gerrit-Change-Number: 19026
Gerrit-PatchSet: 5
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 23:36:10 +0000
Gerrit-HasComments: No