You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2013/12/03 16:21:35 UTC
[jira] [Commented] (OAK-1256) Dead code in
PrivilegeBitsProvider#getPrivilegeNames
[ https://issues.apache.org/jira/browse/OAK-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837783#comment-13837783 ]
angela commented on OAK-1256:
-----------------------------
hm... i'd rather not add hashcode/equals to the modifiable data but rather use the unmodifiable presentation for the lookup.
> Dead code in PrivilegeBitsProvider#getPrivilegeNames
> ----------------------------------------------------
>
> Key: OAK-1256
> URL: https://issues.apache.org/jira/browse/OAK-1256
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Antonio Sanso
> Attachments: OAK-1256-patch.txt
>
>
> There is some dead code in PrivilegeBitsProvider#getPrivilegeNames due the lack of hashCode/equals in PrivileveBits$ModifiableData
> More specifically
> {code}
> Set<String> privilegeNames;
> if (bitsToNames.containsKey(privilegeBits)) {
> privilegeNames = bitsToNames.get(privilegeBits);
> } else {
> {code}
> will always be false. Patch to follow
--
This message was sent by Atlassian JIRA
(v6.1#6144)