[GitHub] [pulsar] mattisonchao commented on a change in pull request #14643: Changing the topic creation flow and optimize heartbeat topic not trigger compaction.

[GitBox <gi...@apache.org>]

mattisonchao commented on a change in pull request #14643:
URL: https://github.com/apache/pulsar/pull/14643#discussion_r825409041



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SystemTopic.java
##########
@@ -70,8 +72,11 @@ public void checkGC() {
     }
 
     @Override
-    public CompletableFuture<Boolean> isCompactionEnabled() {
-        // All system topics are using compaction, even though is not explicitly set in the policies.
-        return CompletableFuture.completedFuture(true);
+    public boolean isCompactionEnabled() {
+        // All system topics are using compaction except `HealthCheck`,
+        // even though is not explicitly set in the policies.
+        TopicName name = TopicName.get(topic);
+        NamespaceName heartbeatNamespace = brokerService.pulsar().getHeartbeatNamespaceV2();

Review comment:
       Should we be compatible with versions prior to v2?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org