You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/05 19:49:21 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #2065:
[NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
lkishalmi opened a new pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065
I had to move The Gradle Tooling API lib to its own module as sigtest would likely to fail on upgrades. That resulted a release version bump on other modules dependent Gradle modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers commented on issue #2065: [NETBEANS-4118]
Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
svenreimers commented on issue #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#issuecomment-609476717
So should this be targeted to 12.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to
version 6.3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405106799
##########
File path: groovy/gradle/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
AutoUpdate-Show-In-Client: false
-OpenIDE-Module: org.netbeans.modules.gradle/1
+OpenIDE-Module: org.netbeans.modules.gradle/2
OpenIDE-Module-Layer: org/netbeans/modules/gradle/layer.xml
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/gradle/Bundle.properties
OpenIDE-Module-Specification-Version: 1.6
Review comment:
If the release version is bumped, I would also bump the specification version. In this case to `2.0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2065:
[NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405282759
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
Review comment:
Yes that shall be removed, setting the module loading to regular.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #2065:
[NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#issuecomment-611724008
Moving should be uncritical. It changes location of the module, but not the logical data. We moved some libraries in this cycle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to
version 6.3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405110958
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
+nbm.needs.restart=true
+
+javac.source=1.8
+javac.compilerargs=-Xlint -Xlint:-serial
+
+# For more information, please see http://wiki.netbeans.org/SignatureTest
+sigtest.gen.fail.on.error=false
Review comment:
Wouldn't it make sense to run sigtest - this could detect incompatible changes and indicate when using modules need to be checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #2065: [NETBEANS-4118]
Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#issuecomment-611715114
@matthiasblaesing With my plan to move the Gradle Support out of Groovy beyond 12.0, would it be better to define this module in the IDE cluster right now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers edited a comment on issue #2065:
[NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
svenreimers edited a comment on issue #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#issuecomment-609476717
So should this be targeted to 12.0? Ups, just saw the label attached...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2065:
[NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405282481
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
+nbm.needs.restart=true
+
+javac.source=1.8
+javac.compilerargs=-Xlint -Xlint:-serial
+
+# For more information, please see http://wiki.netbeans.org/SignatureTest
+sigtest.gen.fail.on.error=false
Review comment:
Well, I stole that line from the libs.groovy module. As these Gradle Tooling update happens in a controlled way the dependent modules are checked as well.
What should be the procedure if I leave this one true and the sigtest fails? I would not like to bump the release-version of this module in that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to
version 6.3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405110258
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
Review comment:
Should this not be `false`? The module should become active if a using module becomes active, but not by itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2065: [NETBEANS-4118]
Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #2065: [NETBEANS-4118]
Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#issuecomment-609472324
Oh, BTW Gradle 6.3 is the first version supporting Java 14.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to
version 6.3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405737097
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
+nbm.needs.restart=true
+
+javac.source=1.8
+javac.compilerargs=-Xlint -Xlint:-serial
+
+# For more information, please see http://wiki.netbeans.org/SignatureTest
+sigtest.gen.fail.on.error=false
Review comment:
Why not bump the release version? The benefit I see is, that everybody is aware that a potentially problematic update happened.
The last time JNA was updated, it transitioned from 4.X to 5.Y and as this might break thing I bumped release version. All modules that depend on JNA had to be updated but that was not so much work - having all modules open checks for compatibility can directly applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2065:
[NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405854908
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
+nbm.needs.restart=true
+
+javac.source=1.8
+javac.compilerargs=-Xlint -Xlint:-serial
+
+# For more information, please see http://wiki.netbeans.org/SignatureTest
+sigtest.gen.fail.on.error=false
Review comment:
Between Gradle 6.0 and 6.3 Gradle changed some API-s which are in incubation. And according to their practices, they are free to do that. The stable API-s remains unchanged between major versions. Probably the release version can go by the major version, I'm going to modify this PR according to that, but I still think sigtests would be an unnecessary overhead in this process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2065:
[NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405282759
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
Review comment:
Yes that shall be removed, butting the module loading to regular.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #2065: [NETBEANS-4118]
Moved Gradle Tooling into its own module and to version 6.3
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#issuecomment-612198092
Travis errors are timeouts on tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to
version 6.3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r406428348
##########
File path: groovy/libs.gradle/nbproject/project.properties
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
+nbm.needs.restart=true
+
+javac.source=1.8
+javac.compilerargs=-Xlint -Xlint:-serial
+
+# For more information, please see http://wiki.netbeans.org/SignatureTest
+sigtest.gen.fail.on.error=false
Review comment:
Ok - I see. With that informatio it indeed makes no sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists