You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/31 00:45:18 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
nytai opened a new pull request #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
URL: https://github.com/apache/incubator-superset/pull/9057
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
sets the feature flag SQLLAB_BACKEND_PERSISTENCE as off by default
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on issue #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
URL: https://github.com/apache/incubator-superset/pull/9057#issuecomment-580530492
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
URL: https://github.com/apache/incubator-superset/pull/9057#issuecomment-580531474
oops, looks like this is a test file. I thought this was the main config file. Please ignore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
URL: https://github.com/apache/incubator-superset/pull/9057#issuecomment-580531877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9057?src=pr&el=h1) Report
> Merging [#9057](https://codecov.io/gh/apache/incubator-superset/pull/9057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9f4d8a509083a6f8c017f709ecda5ce7ed2989d7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9057 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11747 11747
Branches 2888 2888
=======================================
Hits 6984 6984
Misses 4584 4584
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9057?src=pr&el=footer). Last update [9f4d8a5...d77162a](https://codecov.io/gh/apache/incubator-superset/pull/9057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai closed pull request #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
Posted by GitBox <gi...@apache.org>.
nytai closed pull request #9057: [sqllab] update config to set SQLLAB_BACKEND_PERSISTENCE feature flag…
URL: https://github.com/apache/incubator-superset/pull/9057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org