You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Gary-Hobson (via GitHub)" <gi...@apache.org> on 2024/10/13 05:10:09 UTC
[PR] telenet: fix telenet compilation error when system_nsh is not enabled [nuttx-apps]
Gary-Hobson opened a new pull request, #2713:
URL: https://github.com/apache/nuttx-apps/pull/2713
## Summary
telenet: fix telenet compilation error when system_nsh is not enabled
telnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' undeclared (first use in this function); did you mean 'CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY'?
57 | CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] telenet: fix telenet compilation error when system_nsh is not enabled [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2713:
URL: https://github.com/apache/nuttx-apps/pull/2713#discussion_r1798114344
##########
system/telnetd/Kconfig:
##########
@@ -40,6 +40,6 @@ config SYSTEM_TELNETD_SESSION_PRIORITY
config SYSTEM_TELNETD_SESSION_STACKSIZE
int "Telnetd session task stack size"
- default SYSTEM_NSH_STACKSIZE
+ default DEFAULT_TASK_STACKSIZE
Review Comment:
why not revert https://github.com/apache/nuttx-apps/pull/2706 or wait https://github.com/apache/nuttx-apps/pull/2716?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] telenet: fix telenet compilation error when system_nsh is not enabled [nuttx-apps]
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson closed pull request #2713: telenet: fix telenet compilation error when system_nsh is not enabled
URL: https://github.com/apache/nuttx-apps/pull/2713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] telenet: fix telenet compilation error when system_nsh is not enabled [nuttx-apps]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2713:
URL: https://github.com/apache/nuttx-apps/pull/2713#issuecomment-2408833862
Sorry there's a typo in the PR title: "telenet" should be "telnet". Thanks :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] telenet: fix telenet compilation error when system_nsh is not enabled [nuttx-apps]
Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI commented on PR #2713:
URL: https://github.com/apache/nuttx-apps/pull/2713#issuecomment-2409826960
Already handle at:
https://github.com/apache/nuttx-apps/pull/2716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org