You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/02/12 18:45:09 UTC

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12455


Change subject: fs: enable runtime container deletion for block_manager-stress-test
......................................................................

fs: enable runtime container deletion for block_manager-stress-test

This was previously disabled because we saw a SIGSEGV in
block_manager-stress-test. To facilitate digging in, this re-enables it
for the test.

Change-Id: Ic0d0a6b9305f40c3dfccb42903becc6bb2bf6383
---
M src/kudu/fs/block_manager-stress-test.cc
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12455/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0d0a6b9305f40c3dfccb42903becc6bb2bf6383
Gerrit-Change-Number: 12455
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12455 )

Change subject: fs: enable runtime container deletion for block_manager-stress-test
......................................................................

fs: enable runtime container deletion for block_manager-stress-test

This was previously disabled because we saw a SIGSEGV in
block_manager-stress-test. To facilitate digging in, this re-enables it
for the test.

Change-Id: Ic0d0a6b9305f40c3dfccb42903becc6bb2bf6383
Reviewed-on: http://gerrit.cloudera.org:8080/12455
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/fs/block_manager-stress-test.cc
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Andrew Wong: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0d0a6b9305f40c3dfccb42903becc6bb2bf6383
Gerrit-Change-Number: 12455
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: fs: enable runtime container deletion for block_manager-stress-test
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/12455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic0d0a6b9305f40c3dfccb42903becc6bb2bf6383
Gerrit-Change-Number: 12455
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12455 )

Change subject: fs: enable runtime container deletion for block_manager-stress-test
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d0a6b9305f40c3dfccb42903becc6bb2bf6383
Gerrit-Change-Number: 12455
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 18:49:17 +0000
Gerrit-HasComments: No

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12455 )

Change subject: fs: enable runtime container deletion for block_manager-stress-test
......................................................................


Patch Set 1: Verified+1

The failure is KUDU-2686, which I am looking into. It's unrelated to this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/12455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d0a6b9305f40c3dfccb42903becc6bb2bf6383
Gerrit-Change-Number: 12455
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 23:12:31 +0000
Gerrit-HasComments: No