You are viewing a plain text version of this content. The canonical link for it is here.
Posted to watchdog-dev@jakarta.apache.org by rl...@apache.org on 2001/12/18 04:34:56 UTC
cvs commit: jakarta-watchdog-4.0/src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet_http/HttpServletRequest GetMethod_HEADTestServlet.java
rlubke 01/12/17 19:34:56
Modified: src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet_http/HttpServletRequest
GetMethod_HEADTestServlet.java
Log:
Test success was dependant on a response body being returned.
This is incorrect as the HEAD request method only returns
response headers.
Updated the test so that response.sendError was used
to indicate test failure/success.
Retained an out.println() statement to assert on
the client side that no response body is returned
to the client.
Revision Changes Path
1.2 +6 -9 jakarta-watchdog-4.0/src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet_http/HttpServletRequest/GetMethod_HEADTestServlet.java
Index: GetMethod_HEADTestServlet.java
===================================================================
RCS file: /home/cvs/jakarta-watchdog-4.0/src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet_http/HttpServletRequest/GetMethod_HEADTestServlet.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- GetMethod_HEADTestServlet.java 2000/10/16 22:38:56 1.1
+++ GetMethod_HEADTestServlet.java 2001/12/18 03:34:56 1.2
@@ -1,6 +1,6 @@
/*
- * $Header: /home/cvs/jakarta-watchdog-4.0/src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet_http/HttpServletRequest/GetMethod_HEADTestServlet.java,v 1.1 2000/10/16 22:38:56 santosh Exp $
- * $Date: 2000/10/16 22:38:56 $
+ * $Header: /home/cvs/jakarta-watchdog-4.0/src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet_http/HttpServletRequest/GetMethod_HEADTestServlet.java,v 1.2 2001/12/18 03:34:56 rlubke Exp $
+ * $Date: 2001/12/18 03:34:56 $
*
* The Apache Software License, Version 1.1
*
@@ -81,19 +81,16 @@
public void service (HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
PrintWriter out = response.getWriter();
-
+ // just to validate that a response body isn't returned.
+ out.println( "Arbitrary text..." );
String method = request.getMethod();
if(method!=null) {
if(method.trim().equalsIgnoreCase("HEAD"))
{
- out.println("GetMethod_HEADTest test PASSED");
+ response.sendError( HttpServletResponse.SC_OK, "GetMethod_HEADTest PASSED" );
return;
}
}
- out.println("GetMethod_HEADTest test FAILED");
- out.println( "<BR>getMethod did not return proper method type");
- out.println("Actual Return Value : " + method );
- out.println("Expected Return Value : HEAD " );
-
+ response.sendError( HttpServletResponse.SC_INTERNAL_SERVER_ERROR, "GetMethod_HEADTest FAILED" );
}
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>