You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/05 17:53:24 UTC
[GitHub] [fineract] nazeer1100126 opened a new pull request #825: Fix for FINERACT-894
nazeer1100126 opened a new pull request #825:
URL: https://github.com/apache/fineract/pull/825
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-624219562
@nazeer1100126 I noticed your previous #823 #824, because I "watch" this repo on GitHub. FYI Yyou don't need to create N new PRs the same thing just to re-launch a Travis CI build, which is why I suspect you're doing this? Just closing and re-opening just cause a new build. Or you can add a newline and force push :smile:
As for the test failures, please read and follow https://github.com/apache/fineract#pull-requests which we recently added, see the "New Policy about how to deal with unstable tests" thread on the Fineract Dev list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-624433712
@nazeer1100126 this should pass if you rebase now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-652709600
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-636717383
@nazeer1100126 respectfully pinging you if you are still interested to do a rebase to get this in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-633090251
@nazeer1100126 FYI https://github.com/cirrus-actions/rebase/issues/48 explains how you can make the slash rebase bot work for us when you contribute to this project. (You can also just "locally" do a traditional rebase as always and force push, of course.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-633072964
> /rebase
[looks like this doesn't work here](https://github.com/apache/fineract/runs/702179667?check_suite_focus=true)
@nazeer1100126 you need to rebase this PR yourself if you would like this to be reviewed and merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #825:
URL: https://github.com/apache/fineract/pull/825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #825: Fix for FINERACT-894
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-633072403
/rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org