You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/04 18:36:57 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

yangwwei commented on pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230#issuecomment-773520050


   > This test uses 3 different ways to test for a nil error value:
   > 
   > 1. assert.Assert(t, err == nil)
   > 2. assert.Equal(t, err, nil)
   > 3. assert.NilError(t, err,...)
   > 
   > Should be using `assert.NilError()` consistently in the test.
   
   Thanks, fixed in the latest commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org