You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Andy Yeung (JIRA)" <ji...@apache.org> on 2008/02/27 07:54:51 UTC
[jira] Created: (CONFIGURATION-315) CombinedConfiguration fire
EVENT_COMBINED_INVALIDATE even before the contained configuration is
updated
CombinedConfiguration fire EVENT_COMBINED_INVALIDATE even before the contained configuration is updated
-------------------------------------------------------------------------------------------------------
Key: CONFIGURATION-315
URL: https://issues.apache.org/jira/browse/CONFIGURATION-315
Project: Commons Configuration
Issue Type: Bug
Components: Events & Notifications
Affects Versions: 1.5
Environment: Any
Reporter: Andy Yeung
CombinedConfiguration.configurationChanged doesn't check the !event.isBeforeUpdate() and trigger the invalidate call. The invalidate call fire the EVENT_COMBINED_INVALIDATE. so now when a contained config is changed, EVENT_COMBINED_INVALIDATE is fired twice by the CombinedConfiguration. However it should only fire it after the contained FileConfiguration is updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CONFIGURATION-315) CombinedConfiguration fire
EVENT_COMBINED_INVALIDATE even before the contained configuration is
updated
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Heger resolved CONFIGURATION-315.
----------------------------------------
Resolution: Fixed
You are right: sending two events per change is an inconsistent behavior.
I have applied a fix. The isBeforeUpdate() property of the change event is now taken into account.
Thanks.
> CombinedConfiguration fire EVENT_COMBINED_INVALIDATE even before the contained configuration is updated
> -------------------------------------------------------------------------------------------------------
>
> Key: CONFIGURATION-315
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-315
> Project: Commons Configuration
> Issue Type: Bug
> Components: Events & Notifications
> Affects Versions: 1.5
> Environment: Any
> Reporter: Andy Yeung
> Assignee: Oliver Heger
> Fix For: 1.6
>
>
> CombinedConfiguration.configurationChanged doesn't check the !event.isBeforeUpdate() and trigger the invalidate call. The invalidate call fire the EVENT_COMBINED_INVALIDATE. so now when a contained config is changed, EVENT_COMBINED_INVALIDATE is fired twice by the CombinedConfiguration. However it should only fire it after the contained FileConfiguration is updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CONFIGURATION-315) CombinedConfiguration fire
EVENT_COMBINED_INVALIDATE even before the contained configuration is
updated
Posted by "Emmanuel Bourg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Bourg updated CONFIGURATION-315:
-----------------------------------------
Fix Version/s: 1.6
> CombinedConfiguration fire EVENT_COMBINED_INVALIDATE even before the contained configuration is updated
> -------------------------------------------------------------------------------------------------------
>
> Key: CONFIGURATION-315
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-315
> Project: Commons Configuration
> Issue Type: Bug
> Components: Events & Notifications
> Affects Versions: 1.5
> Environment: Any
> Reporter: Andy Yeung
> Fix For: 1.6
>
>
> CombinedConfiguration.configurationChanged doesn't check the !event.isBeforeUpdate() and trigger the invalidate call. The invalidate call fire the EVENT_COMBINED_INVALIDATE. so now when a contained config is changed, EVENT_COMBINED_INVALIDATE is fired twice by the CombinedConfiguration. However it should only fire it after the contained FileConfiguration is updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-315) CombinedConfiguration fire
EVENT_COMBINED_INVALIDATE even before the contained configuration is
updated
Posted by "Andy Yeung (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572833#action_12572833 ]
Andy Yeung commented on CONFIGURATION-315:
------------------------------------------
I also found that the missing checking of isBeforeUpdate in CombinedConfiguration.configurationChanged sometimes mess up the detailEvents in XMLConfiguration contained in CombinedConfiguration. This would prevent !isBeforeUpdate event to sent out to CombinedConfiguration listener, when XMLConfiguration receive the event from its delegate in some cases. (this cases not always occur but happen occasionally). The detailEvents is -1 in that cases.
> CombinedConfiguration fire EVENT_COMBINED_INVALIDATE even before the contained configuration is updated
> -------------------------------------------------------------------------------------------------------
>
> Key: CONFIGURATION-315
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-315
> Project: Commons Configuration
> Issue Type: Bug
> Components: Events & Notifications
> Affects Versions: 1.5
> Environment: Any
> Reporter: Andy Yeung
>
> CombinedConfiguration.configurationChanged doesn't check the !event.isBeforeUpdate() and trigger the invalidate call. The invalidate call fire the EVENT_COMBINED_INVALIDATE. so now when a contained config is changed, EVENT_COMBINED_INVALIDATE is fired twice by the CombinedConfiguration. However it should only fire it after the contained FileConfiguration is updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.