You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/11/06 10:57:53 UTC

[GitHub] [incubator-hudi] leesf commented on a change in pull request #995: [HUDI-253]: added validations for schema provider class

leesf commented on a change in pull request #995: [HUDI-253]: added validations for schema provider class
URL: https://github.com/apache/incubator-hudi/pull/995#discussion_r343033196
 
 

 ##########
 File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/InputBatch.java
 ##########
 @@ -48,6 +49,9 @@ public String getCheckpointForNextBatch() {
   }
 
   public SchemaProvider getSchemaProvider() {
+    if (schemaProvider == null) {
+      throw new HoodieException("Please provide a valid schema provider class!");
+    }
 
 Review comment:
   This change affects the TestHoodieDeltaStreamer#testBulkInsertsAndUpsertsWithSQLBasedTransformerFor2StepPipeline, and the UT should be changed as well. You could click the details below to get travis detail message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services