You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/01/29 19:07:14 UTC

[GitHub] spark pull request #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local...

GitHub user jiangxb1987 opened a pull request:

    https://github.com/apache/spark/pull/20426

    [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort for DataFrame.repartition(1)

    ## What changes were proposed in this pull request?
    
    In `ShuffleExchangeExec`, we don't need to insert extra local sort before round-robin partitioning, if the new partitioning has only 1 partition, because under that case all output rows go to the same partition.
    
    ## How was this patch tested?
    
    The existing test cases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiangxb1987/spark repartition1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20426
    
----
commit 2c9ee7f8fd22ffdff250da9ae2709dfbcaea7342
Author: Xingbo Jiang <xi...@...>
Date:   2018-01-29T18:49:06Z

    improve DataFrame.repartition(1).

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort f...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20426
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort f...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20426
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort f...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20426
  
    **[Test build #86785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86785/testReport)** for PR 20426 at commit [`5fa8de3`](https://github.com/apache/spark/commit/5fa8de3151e94377b0f204e74dedbca9ffb2e306).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort f...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20426
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/345/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort f...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20426
  
    **[Test build #86785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86785/testReport)** for PR 20426 at commit [`5fa8de3`](https://github.com/apache/spark/commit/5fa8de3151e94377b0f204e74dedbca9ffb2e306).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort f...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20426
  
    **[Test build #86778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86778/testReport)** for PR 20426 at commit [`2c9ee7f`](https://github.com/apache/spark/commit/2c9ee7f8fd22ffdff250da9ae2709dfbcaea7342).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20426: [SPARK-23207][SQL][FOLLOW-UP] Don't perform local sort f...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20426
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86785/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org